Re: [PATCH] Have SIGTERM promptly quit GDB even when the dummy target is active

Patrick Palka
2015-07-27T15:44:16Z

On Mon, Jul 27, 2015 at 11:21 AM, Pedro Alves <palves@redhat.com> wrote:
> On 07/27/2015 03:53 PM, Pedro Alves wrote:
>> On 07/24/2015 07:33 PM, Patrick Palka wrote:
>>
>>> gdb/ChangeLog:
>>>
>>> * event-top.c (handle_sigterm): Don't inspect
>>> target_can_async_p. Always set the quit flag and always mark
>>> the async signal handler.
>>
>> OK.
>
> BTW, I notice that GDB leaves the terminal settings broken
> after exiting on SIGTERM. Is that something you're already
> looking at? (Mostly likely there's a target_terminal_ours
> missing somewhere.)

I think we should do target_terminal_ours in quit_force. (A similar
problem also exists in our SIGWINCH handler.)