Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

Don Breazeal
2015-09-15T16:12:18Z

On 9/15/2015 1:56 AM, Yao Qi wrote:
> Don Breazeal <donb@codesourcery.com> writes:
>
> Hi Don,
> I happen to read the code you pushed in some days ago...
>
>> @@ -2111,6 +2112,12 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
>> if (target_supports_vfork_events ())
>> report_vfork_events = 1;
>> }
>> + if (strcmp (p, "exec-events+") == 0)
>
> Shouldn't we use "else if"?

Hi Yao,
Yes, definitely "else if". Fortunately this didn't break anything. Do
you want to go ahead and push the fix, or shall I do it?
thanks
--Don

>
>> + {
>> + /* GDB supports and wants exec events if possible. */
>> + if (target_supports_exec_events ())
>> + report_exec_events = 1;
>> + }
>> else
>> target_process_qsupported (p);
>