Re: [PATCH v3 3/4] Extended-remote support for exec event tests

Pedro Alves
2015-09-10T13:26:11Z

Hi Don,

This is OK. One nit below.

On 09/10/2015 12:05 AM, Don Breazeal wrote:

>> Note that schedlock on has no effect in non-stop mode.
>> Maybe if !lock_sched && nonstop, we could issue "continue -a"
>> instead of continue.
>
> I couldn't find any documentation of 'continue -a'. (?) I just used
> a conditional to prevent running the lock_sched/nonstop tests.

I see that the "Continuing and Stepping" section doesn't mention
it. It's mentioned in "help continue", and here in the manual:

In non-stop mode, all execution commands apply only to the current thread
by default. That is, @code{continue} only continues one thread.
To continue all threads, issue @code{continue -a} or @code{c -a}.

> diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp b/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp
> index 69e5cc6..3e5c902 100644
> --- a/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp
> +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp
> @@ -28,11 +28,14 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
> return -1
> }
>
> -proc do_test { lock_sched } {
> - with_test_prefix "lock-sched$lock_sched" {
> +proc do_test { lock_sched nonstop } {
> + with_test_prefix "lock-sched$lock_sched,non-stop$nonstop" {

AFAICS, this will render as:

lock-schedoff,non-stopon

etc. I suggest adding a '=':

with_test_prefix "lock-sched=$lock_sched,non-stop=$nonstop" {

(in the other files too, of course.)

Thanks,
Pedro Alves