Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH 09/14] Factor out bool printing code from generic_val_print
Date: Wed, 15 Jul 2015 16:48:00 -0000	[thread overview]
Message-ID: <1436978863-15125-10-git-send-email-simon.marchi@ericsson.com> (raw)
In-Reply-To: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com>

gdb/ChangeLog:

	* valprint.c (generic_val_print): Factor out bool
	printing code to ...
	(generic_val_print_bool): ... this new function.
---
 gdb/valprint.c | 51 +++++++++++++++++++++++++++++++++------------------
 1 file changed, 33 insertions(+), 18 deletions(-)

diff --git a/gdb/valprint.c b/gdb/valprint.c
index d2ca244..7b90971 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -623,6 +623,37 @@ generic_val_print_func (struct type *type, const gdb_byte *valaddr,
     }
 }
 
+/* generic_val_print helper for TYPE_CODE_BOOL.  */
+
+static void
+generic_val_print_bool (struct type *type, const gdb_byte *valaddr,
+			int embedded_offset, struct ui_file *stream,
+			const struct value *original_value,
+			const struct value_print_options *options,
+			const struct generic_val_print_decorations *decorations)
+{
+  LONGEST val;
+
+  if (options->format || options->output_format)
+    {
+      struct value_print_options opts = *options;
+      opts.format = (options->format ? options->format
+		     : options->output_format);
+      val_print_scalar_formatted (type, valaddr, embedded_offset,
+				  original_value, &opts, 0, stream);
+    }
+  else
+    {
+      val = unpack_long (type, valaddr + embedded_offset);
+      if (val == 0)
+	fputs_filtered (decorations->false_name, stream);
+      else if (val == 1)
+	fputs_filtered (decorations->true_name, stream);
+      else
+	print_longest (stream, 'd', 0, val);
+    }
+}
+
 /* A generic val_print that is suitable for use by language
    implementations of the la_val_print method.  This function can
    handle most type codes, though not all, notably exception
@@ -685,24 +716,8 @@ generic_val_print (struct type *type, const gdb_byte *valaddr,
       break;
 
     case TYPE_CODE_BOOL:
-      if (options->format || options->output_format)
-	{
-	  struct value_print_options opts = *options;
-	  opts.format = (options->format ? options->format
-			 : options->output_format);
-	  val_print_scalar_formatted (type, valaddr, embedded_offset,
-				      original_value, &opts, 0, stream);
-	}
-      else
-	{
-	  val = unpack_long (type, valaddr + embedded_offset);
-	  if (val == 0)
-	    fputs_filtered (decorations->false_name, stream);
-	  else if (val == 1)
-	    fputs_filtered (decorations->true_name, stream);
-	  else
-	    print_longest (stream, 'd', 0, val);
-	}
+      generic_val_print_bool (type, valaddr, embedded_offset, stream,
+			      original_value, options, decorations);
       break;
 
     case TYPE_CODE_RANGE:
-- 
2.1.4


  parent reply	other threads:[~2015-07-15 16:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 16:47 [PATCH 00/14] Split generic_val_print in smaller parts Simon Marchi
2015-07-15 16:47 ` [PATCH 04/14] Factor out memberptr printing code from generic_val_print Simon Marchi
2015-07-15 16:47 ` [PATCH 01/14] Factor out print_unpacked_pointer " Simon Marchi
2015-07-23 21:45   ` Pedro Alves
2015-07-24  2:29     ` Simon Marchi
2015-07-27 18:16     ` Simon Marchi
2015-07-15 16:47 ` [PATCH 06/14] Factor out enum printing code " Simon Marchi
2015-07-15 16:48 ` [PATCH 11/14] Factor out char " Simon Marchi
2015-07-23 21:46   ` Pedro Alves
2015-07-27 18:17     ` Simon Marchi
2015-07-15 16:48 ` [PATCH 02/14] Factor out array " Simon Marchi
2015-07-15 16:48 ` Simon Marchi [this message]
2015-07-15 16:48 ` [PATCH 13/14] Factor out decfloat " Simon Marchi
2015-07-15 16:48 ` [PATCH 03/14] Factor out pointer " Simon Marchi
2015-07-15 16:48 ` [PATCH 05/14] Factor out reference " Simon Marchi
2015-07-15 16:48 ` [PATCH 10/14] Factor out int " Simon Marchi
2015-07-15 16:48 ` [PATCH 12/14] Factor out float " Simon Marchi
2015-07-23 21:46   ` Pedro Alves
2015-07-27 18:18     ` Simon Marchi
2015-07-15 16:48 ` [PATCH 07/14] Factor out flags " Simon Marchi
2015-07-15 16:48 ` [PATCH 14/14] Factor out complex " Simon Marchi
2015-07-15 16:48 ` [PATCH 08/14] Factor out function/method " Simon Marchi
2015-07-23 21:45   ` Pedro Alves
2015-07-27 18:17     ` Simon Marchi
2015-07-23 21:54 ` [PATCH 00/14] Split generic_val_print in smaller parts Pedro Alves
2015-07-27 18:14   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436978863-15125-10-git-send-email-simon.marchi@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox