From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5439 invoked by alias); 8 Jul 2015 21:08:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5408 invoked by uid 89); 8 Jul 2015 21:08:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 08 Jul 2015 21:08:15 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id E9.A4.07675.5E92D955; Wed, 8 Jul 2015 15:47:18 +0200 (CEST) Received: from elxcz23q12-y4.dyn.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.87) with Microsoft SMTP Server (TLS) id 14.3.210.2; Wed, 8 Jul 2015 17:08:10 -0400 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 0/7] Split c_val_print Date: Wed, 08 Jul 2015 21:08:00 -0000 Message-ID: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00261.txt.bz2 I think that c_val_print deserves to be split up in smaller, more manageable chunks. This series does that, by simply factoring out each case of the big switch. In some cases, a bit of modifications were necessary where fallthrough between cases or goto were used, but otherwise the code stays the same. Simon Marchi (7): Remove unneeded variable assignment Factor out print_unpacked_pointer from c_val_print Factor out array printing code from c_val_print Factor out pointer printing code from c_val_print Factor out struct and union printing code from c_val_print Factor out int printing code from c_val_print Factor out memberptr printing code from c_val_print gdb/c-valprint.c | 612 ++++++++++++++++++++++++++++++++----------------------- 1 file changed, 352 insertions(+), 260 deletions(-) -- 2.1.4