Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: palves@redhat.com
Cc: gdb-patches@sourceware.org
Subject: [PATCH 1/4] btrace: fix build fail with 32-bit BFD
Date: Wed, 08 Jul 2015 12:54:00 -0000	[thread overview]
Message-ID: <1436360074-8625-1-git-send-email-markus.t.metzger@intel.com> (raw)

When compiling GDB with 32-bit BFD, the build fails with:

In file included from btrace.h:33:0,
                 from btrace.c:23:
/usr/include/intel-pt.h:1643:51: note: expected 'int (*)(uint8_t *, size_t,
 const struct pt_asid *, uint64_t, void *)' but argument is of type 'int
 (*)(gdb_byte *, size_t, const struct pt_asid *, CORE_ADDR, void *)' extern
 pt_export int pt_image_set_callback(struct pt_image *image, ^

Fix it.

2015-07-08  Markus Metzger <markus.t.metzger@intel.com>

gdb/
	* btrace.c (btrace_pt_readmem_callback): Change type of PC argument.
---
 gdb/btrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/btrace.c b/gdb/btrace.c
index b924e7d..1618e55 100644
--- a/gdb/btrace.c
+++ b/gdb/btrace.c
@@ -824,14 +824,14 @@ ftrace_add_pt (struct pt_insn_decoder *decoder,
 
 static int
 btrace_pt_readmem_callback (gdb_byte *buffer, size_t size,
-			    const struct pt_asid *asid, CORE_ADDR pc,
+			    const struct pt_asid *asid, uint64_t pc,
 			    void *context)
 {
   int errcode;
 
   TRY
     {
-      errcode = target_read_code (pc, buffer, size);
+      errcode = target_read_code ((CORE_ADDR) pc, buffer, size);
       if (errcode != 0)
 	return -pte_nomap;
     }
-- 
1.8.3.1


             reply	other threads:[~2015-07-08 12:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 12:54 Markus Metzger [this message]
2015-07-08 12:54 ` [PATCH 3/4] ari, btrace: avoid unsigned long long Markus Metzger
2015-07-08 13:40   ` Pedro Alves
2015-07-08 14:05     ` Metzger, Markus T
2015-07-08 12:54 ` [PATCH 2/4] record: set stop_pc in "record goto" command Markus Metzger
2015-07-08 13:42   ` Pedro Alves
2015-07-08 15:08     ` Metzger, Markus T
2015-07-08 15:11       ` Pedro Alves
2015-07-08 12:54 ` [PATCH 4/4] btrace, pt: support new packets Markus Metzger
2015-07-08 13:45   ` Pedro Alves
2015-07-08 13:42 ` [PATCH 1/4] btrace: fix build fail with 32-bit BFD Pedro Alves
2015-07-13  7:39   ` Metzger, Markus T
2015-07-13  9:39     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436360074-8625-1-git-send-email-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox