Re: Several regressions and we branch soon.

Doug Evans
2015-06-25T13:34:58Z

On Thu, Jun 25, 2015 at 3:21 AM, Andreas Arnez <arnez@linux.vnet.ibm.com> wrote:
> On Wed, Jun 24 2015, Yao Qi wrote:
>
>> Doug Evans <dje@google.com> writes:
>>
>>> FAIL: gdb.base/gnu_vector.exp: call add_singlevecs
>>
>> I see this fail too,
>> print add_singlevecs((char1) {6}, (int1) {12}, (double1) {24})^M
>> ^M
>> Program received signal SIGSEGV, Segmentation fault.^M
>> 0x00000000004008ec in add_singlevecs (a=..., b=..., c=...) at ../../../../../binutils-gdb/gdb/testsuite/gdb.base/gnu_vector.c:132^M
>> 132 return (double1) {a[0] + b[0] + c[0]};^M
>> The program being debugged was signaled while in a function called from GDB.^M
>> GDB remains in the frame where the signal was received.^M
>> To change this behavior use "set unwindonsignal on".^M
>> Evaluation of the expression containing the function^M
>> (add_singlevecs) will be abandoned.^M
>> When the function is done executing, GDB will silently stop.^M
>> (gdb) FAIL: gdb.base/gnu_vector.exp: call add_singlevecs
>
> This is not a regression in GDB, but a new test uncovering GDB's missing
> vector ABI support on x86_64. So for the branch I suggest to suppress
> these new FAILs with gnu_vector.exp -- either in the test case or in the
> test harness.

Any reason to not mark them as K/XFAILs in the master branch?
We should avoid adding new tests the we know are going to FAIL (*1).
And indeed I see discussion in the submission about that.
https://sourceware.org/ml/gdb-patches/2015-05/msg00319.html
So we're good there.
The question remains though: why are these failing?

---
(*1): It should be a rule in the contribution checklist.
https://sourceware.org/gdb/wiki/ContributionChecklist

It's not, but if I dig a bit deeper, it is:
"Known failing new testcases must produce KFAIL (GDB problem) or XFAIL
(environment problem)."
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook

I added a bit more text to the checklist so one doesn't have to dig to see it.