From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 01/11] Remove {fetch,store}_fpregister and {fetch,store}_register
Date: Wed, 01 Jul 2015 13:58:00 -0000 [thread overview]
Message-ID: <1435759111-22856-2-git-send-email-yao.qi@linaro.org> (raw)
In-Reply-To: <1435759111-22856-1-git-send-email-yao.qi@linaro.org>
This patch is to remove fetch_fpregister, fech_register,
store_fpregister and store_register, and use fetch_fpregs,
fetch_regs, store_regs, and store_fpregs instead.
gdb:
2015-06-23 Yao Qi <yao.qi@linaro.org>
* arm-linux-nat.c (store_fpregister): Remove.
(store_register): Likewise.
(fetch_fpregister): Likewise.
(fetch_register): Likewise.
(arm_linux_store_inferior_registers): Call store_regs and
store_fpregs instead.
(arm_linux_fetch_inferior_registers): Call fetch_fpregs and
fetch_regs instead.
---
gdb/arm-linux-nat.c | 223 +---------------------------------------------------
1 file changed, 4 insertions(+), 219 deletions(-)
diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index c167bce..5a8880f 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -82,47 +82,6 @@ get_thread_id (ptid_t ptid)
#define GET_THREAD_ID(PTID) get_thread_id (PTID)
-/* Get the value of a particular register from the floating point
- state of the process and store it into regcache. */
-
-static void
-fetch_fpregister (struct regcache *regcache, int regno)
-{
- int ret, tid;
- gdb_byte fp[ARM_LINUX_SIZEOF_NWFPE];
-
- /* Get the thread id for the ptrace call. */
- tid = GET_THREAD_ID (inferior_ptid);
-
- /* Read the floating point state. */
- if (have_ptrace_getregset == TRIBOOL_TRUE)
- {
- struct iovec iov;
-
- iov.iov_base = &fp;
- iov.iov_len = ARM_LINUX_SIZEOF_NWFPE;
-
- ret = ptrace (PTRACE_GETREGSET, tid, NT_FPREGSET, &iov);
- }
- else
- ret = ptrace (PT_GETFPREGS, tid, 0, fp);
-
- if (ret < 0)
- {
- warning (_("Unable to fetch floating point register."));
- return;
- }
-
- /* Fetch fpsr. */
- if (ARM_FPS_REGNUM == regno)
- regcache_raw_supply (regcache, ARM_FPS_REGNUM,
- fp + NWFPE_FPSR_OFFSET);
-
- /* Fetch the floating point register. */
- if (regno >= ARM_F0_REGNUM && regno <= ARM_F7_REGNUM)
- supply_nwfpe_register (regcache, regno, fp);
-}
-
/* Get the whole floating point state of the process and store it
into regcache. */
@@ -163,65 +122,6 @@ fetch_fpregs (struct regcache *regcache)
supply_nwfpe_register (regcache, regno, fp);
}
-/* Save a particular register into the floating point state of the
- process using the contents from regcache. */
-
-static void
-store_fpregister (const struct regcache *regcache, int regno)
-{
- int ret, tid;
- gdb_byte fp[ARM_LINUX_SIZEOF_NWFPE];
-
- /* Get the thread id for the ptrace call. */
- tid = GET_THREAD_ID (inferior_ptid);
-
- /* Read the floating point state. */
- if (have_ptrace_getregset == TRIBOOL_TRUE)
- {
- struct iovec iov;
-
- iov.iov_base = &fp;
- iov.iov_len = ARM_LINUX_SIZEOF_NWFPE;
-
- ret = ptrace (PTRACE_GETREGSET, tid, NT_FPREGSET, &iov);
- }
- else
- ret = ptrace (PT_GETFPREGS, tid, 0, fp);
-
- if (ret < 0)
- {
- warning (_("Unable to fetch the floating point registers."));
- return;
- }
-
- /* Store fpsr. */
- if (ARM_FPS_REGNUM == regno
- && REG_VALID == regcache_register_status (regcache, ARM_FPS_REGNUM))
- regcache_raw_collect (regcache, ARM_FPS_REGNUM, fp + NWFPE_FPSR_OFFSET);
-
- /* Store the floating point register. */
- if (regno >= ARM_F0_REGNUM && regno <= ARM_F7_REGNUM)
- collect_nwfpe_register (regcache, regno, fp);
-
- if (have_ptrace_getregset == TRIBOOL_TRUE)
- {
- struct iovec iov;
-
- iov.iov_base = &fp;
- iov.iov_len = ARM_LINUX_SIZEOF_NWFPE;
-
- ret = ptrace (PTRACE_SETREGSET, tid, NT_FPREGSET, &iov);
- }
- else
- ret = ptrace (PTRACE_SETFPREGS, tid, 0, fp);
-
- if (ret < 0)
- {
- warning (_("Unable to store floating point register."));
- return;
- }
-}
-
/* Save the whole floating point state of the process using
the contents from regcache. */
@@ -282,59 +182,6 @@ store_fpregs (const struct regcache *regcache)
}
}
-/* Fetch a general register of the process and store into
- regcache. */
-
-static void
-fetch_register (struct regcache *regcache, int regno)
-{
- int ret, tid;
- elf_gregset_t regs;
-
- /* Get the thread id for the ptrace call. */
- tid = GET_THREAD_ID (inferior_ptid);
-
- if (have_ptrace_getregset == TRIBOOL_TRUE)
- {
- struct iovec iov;
-
- iov.iov_base = ®s;
- iov.iov_len = sizeof (regs);
-
- ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov);
- }
- else
- ret = ptrace (PTRACE_GETREGS, tid, 0, ®s);
-
- if (ret < 0)
- {
- warning (_("Unable to fetch general register."));
- return;
- }
-
- if (regno >= ARM_A1_REGNUM && regno < ARM_PC_REGNUM)
- regcache_raw_supply (regcache, regno, (char *) ®s[regno]);
-
- if (ARM_PS_REGNUM == regno)
- {
- if (arm_apcs_32)
- regcache_raw_supply (regcache, ARM_PS_REGNUM,
- (char *) ®s[ARM_CPSR_GREGNUM]);
- else
- regcache_raw_supply (regcache, ARM_PS_REGNUM,
- (char *) ®s[ARM_PC_REGNUM]);
- }
-
- if (ARM_PC_REGNUM == regno)
- {
- regs[ARM_PC_REGNUM] = gdbarch_addr_bits_remove
- (get_regcache_arch (regcache),
- regs[ARM_PC_REGNUM]);
- regcache_raw_supply (regcache, ARM_PC_REGNUM,
- (char *) ®s[ARM_PC_REGNUM]);
- }
-}
-
/* Fetch all general registers of the process and store into
regcache. */
@@ -381,68 +228,6 @@ fetch_regs (struct regcache *regcache)
(char *) ®s[ARM_PC_REGNUM]);
}
-/* Store all general registers of the process from the values in
- regcache. */
-
-static void
-store_register (const struct regcache *regcache, int regno)
-{
- int ret, tid;
- elf_gregset_t regs;
-
- if (REG_VALID != regcache_register_status (regcache, regno))
- return;
-
- /* Get the thread id for the ptrace call. */
- tid = GET_THREAD_ID (inferior_ptid);
-
- /* Get the general registers from the process. */
- if (have_ptrace_getregset == TRIBOOL_TRUE)
- {
- struct iovec iov;
-
- iov.iov_base = ®s;
- iov.iov_len = sizeof (regs);
-
- ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov);
- }
- else
- ret = ptrace (PTRACE_GETREGS, tid, 0, ®s);
-
- if (ret < 0)
- {
- warning (_("Unable to fetch general registers."));
- return;
- }
-
- if (regno >= ARM_A1_REGNUM && regno <= ARM_PC_REGNUM)
- regcache_raw_collect (regcache, regno, (char *) ®s[regno]);
- else if (arm_apcs_32 && regno == ARM_PS_REGNUM)
- regcache_raw_collect (regcache, regno,
- (char *) ®s[ARM_CPSR_GREGNUM]);
- else if (!arm_apcs_32 && regno == ARM_PS_REGNUM)
- regcache_raw_collect (regcache, ARM_PC_REGNUM,
- (char *) ®s[ARM_PC_REGNUM]);
-
- if (have_ptrace_getregset == TRIBOOL_TRUE)
- {
- struct iovec iov;
-
- iov.iov_base = ®s;
- iov.iov_len = sizeof (regs);
-
- ret = ptrace (PTRACE_SETREGSET, tid, NT_PRSTATUS, &iov);
- }
- else
- ret = ptrace (PTRACE_SETREGS, tid, 0, ®s);
-
- if (ret < 0)
- {
- warning (_("Unable to store general register."));
- return;
- }
-}
-
static void
store_regs (const struct regcache *regcache)
{
@@ -694,9 +479,9 @@ arm_linux_fetch_inferior_registers (struct target_ops *ops,
else
{
if (regno < ARM_F0_REGNUM || regno == ARM_PS_REGNUM)
- fetch_register (regcache, regno);
+ fetch_regs (regcache);
else if (regno >= ARM_F0_REGNUM && regno <= ARM_FPS_REGNUM)
- fetch_fpregister (regcache, regno);
+ fetch_fpregs (regcache);
else if (tdep->have_wmmx_registers
&& regno >= ARM_WR0_REGNUM && regno <= ARM_WCGR7_REGNUM)
fetch_wmmx_regs (regcache);
@@ -730,9 +515,9 @@ arm_linux_store_inferior_registers (struct target_ops *ops,
else
{
if (regno < ARM_F0_REGNUM || regno == ARM_PS_REGNUM)
- store_register (regcache, regno);
+ store_regs (regcache);
else if ((regno >= ARM_F0_REGNUM) && (regno <= ARM_FPS_REGNUM))
- store_fpregister (regcache, regno);
+ store_fpregs (regcache);
else if (tdep->have_wmmx_registers
&& regno >= ARM_WR0_REGNUM && regno <= ARM_WCGR7_REGNUM)
store_wmmx_regs (regcache);
--
1.9.1
next prev parent reply other threads:[~2015-07-01 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 13:58 [PATCH 00/11] Aarch64 linux GDB native multi-arch debugging (part 1) Yao Qi
2015-07-01 13:58 ` Yao Qi [this message]
2015-07-01 13:58 ` [PATCH 02/11] New aarch32-linux-nat.c Yao Qi
2015-07-01 13:58 ` [PATCH 04/11] Set architecture to arm in arm-*.xml files Yao Qi
2015-07-01 13:58 ` [PATCH 07/11] New proc is_aarch32_target Yao Qi
2015-07-01 13:58 ` [PATCH 08/11] New proc is_aarch64_target Yao Qi
2015-07-01 14:10 ` Andreas Schwab
2015-07-01 14:19 ` Yao Qi
2015-07-01 14:39 ` Andreas Schwab
2015-07-01 13:59 ` [PATCH 05/11] Adjust gdb.multi tests for aarch64 Yao Qi
2015-07-01 13:59 ` [PATCH 06/11] Enable multi-arch test in catch-syscall.exp on aarch64 Yao Qi
2015-07-01 13:59 ` [PATCH 11/11] New target_ops hook to_can_do_single_step Yao Qi
2015-07-01 16:43 ` Pedro Alves
2015-07-02 8:56 ` Yao Qi
2015-07-02 9:09 ` Pedro Alves
2015-07-01 13:59 ` [PATCH 10/11] Reply s and S vCont actions if target supports hardware single step Yao Qi
2015-07-01 13:59 ` [PATCH 03/11] Native debug arm program by aarch64 GDB Yao Qi
2015-07-01 13:59 ` [PATCH 09/11] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step Yao Qi
2015-07-01 17:00 ` [PATCH 00/11] Aarch64 linux GDB native multi-arch debugging (part 1) Pedro Alves
2015-07-01 18:54 ` Pedro Alves
2015-07-02 9:05 ` Yao Qi
2015-07-07 16:13 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435759111-22856-2-git-send-email-yao.qi@linaro.org \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox