From: Walfred Tedeschi <walfred.tedeschi@intel.com>
To: brobecker@adacore.com, eliz@gnu.org
Cc: gdb-patches@sourceware.org,
Walfred Tedeschi <walfred.tedeschi@intel.com>
Subject: [PATCH 1/1] Fix broken GDB build after adding Bound table support for i386.
Date: Wed, 10 Jun 2015 12:46:00 -0000 [thread overview]
Message-ID: <1433940196-22975-1-git-send-email-walfred.tedeschi@intel.com> (raw)
Types used for some variables could not be used for 32 bits.
This patch changes uses larger types to accommodate the biggest integer
possible.
Documentation was also affected, once a different version of texinfo the
docs could not be build.
2015-06-10 Walfred Tedeschi <walfred.tedeschi@intel.com>
* i386-tdep.c (i386_mpx_get_bt_entry): Exchange CORE_ADDR by
ULONGEST.
doc:
gdb.textinfo (i386): Fix "@end table" end and "@table" placement.
---
gdb/doc/gdb.texinfo | 2 ++
gdb/i386-tdep.c | 14 +++++++-------
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 9e9138b..8b4cb88 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22127,6 +22127,7 @@ be returned in a register.
@kindex show struct-convention
Show the current setting of the convention to return @code{struct}s
from functions.
+@end table
@subsubsection Intel(R) @dfn{Memory Protection Extensions} (MPX).
@@ -22168,6 +22169,7 @@ the bounds pointer's value along with its bounds. Evaluating and changing
bounds located in bound tables is therefore interesting while investigating
bugs on MPX context. @value{GDBN} provides commands for this purpose:
+@table @code
@item show mpx bound @var{pointer}
@kindex show mpx bound
Display bounds of the given @var{pointer}.
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 6304591..7de9792 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -8665,13 +8665,13 @@ i386_mpx_enabled (void)
static CORE_ADDR
i386_mpx_get_bt_entry (CORE_ADDR ptr, CORE_ADDR bd_base)
{
- CORE_ADDR offset1;
- CORE_ADDR offset2;
- CORE_ADDR mpx_bd_mask, bd_ptr_r_shift, bd_ptr_l_shift;
- CORE_ADDR bt_mask, bt_select_r_shift, bt_select_l_shift;
- CORE_ADDR bd_entry_addr;
- CORE_ADDR bt_addr;
- CORE_ADDR bd_entry;
+ ULONGEST offset1;
+ ULONGEST offset2;
+ ULONGEST mpx_bd_mask, bd_ptr_r_shift, bd_ptr_l_shift;
+ ULONGEST bt_mask, bt_select_r_shift, bt_select_l_shift;
+ ULONGEST bd_entry_addr;
+ ULONGEST bt_addr;
+ ULONGEST bd_entry;
struct gdbarch *gdbarch = get_current_arch ();
struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
--
2.1.4
next reply other threads:[~2015-06-10 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 12:46 Walfred Tedeschi [this message]
2015-06-10 12:51 ` Tedeschi, Walfred
2015-06-10 14:13 ` Joel Brobecker
2015-06-10 14:56 ` Tedeschi, Walfred
2015-06-11 9:53 ` Tedeschi, Walfred
2015-06-11 16:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433940196-22975-1-git-send-email-walfred.tedeschi@intel.com \
--to=walfred.tedeschi@intel.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox