From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122541 invoked by alias); 2 Jun 2015 07:57:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122528 invoked by uid 89); 2 Jun 2015 07:57:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 02 Jun 2015 07:57:31 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1EB39B72CA; Tue, 2 Jun 2015 07:57:30 +0000 (UTC) Received: from bordewijk.wildebeest.org (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t527vSgH010007 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 2 Jun 2015 03:57:29 -0400 Received: by bordewijk.wildebeest.org (Postfix, from userid 1000) id 6C1C580B5802; Tue, 2 Jun 2015 09:57:28 +0200 (CEST) Message-ID: <1433231848.4538.212.camel@bordewijk.wildebeest.org> Subject: Re: [PATCH 0/6] Use PTRACE_GETREGSET and PTRACE_SETREGSET in arm-linux-nat.c From: Mark Wielaard To: Yao Qi Cc: gdb-patches@sourceware.org Date: Tue, 02 Jun 2015 07:57:00 -0000 In-Reply-To: <556C3F54.2060502@gmail.com> References: <1432822816-32327-1-git-send-email-yao.qi@linaro.org> <556C3F54.2060502@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-SW-Source: 2015-06/txt/msg00010.txt.bz2 Hi Yao, On Mon, 2015-06-01 at 12:17 +0100, Yao Qi wrote: > On 28/05/15 15:20, Yao Qi wrote: > > This patch series is to let GDB arm-linux-nat.c use ptrace commands > > PTRACE_GETREGSET and PTRACE_SETREGSET if linux kernel supports. > > > > Patch #1 and #2 are factoring out macros and variables into more > > common files. Patch #3 checks whether PTRACE_GETREGSET is supported by > > linux kernel. Patch #4 - #6 use PTRACE_{G,S}ETREGSET ptrace commands > > to fetch and store general purpose registers, FP registers and VFP > > registers. > > > > The whole test series are tested on x86_64-linux and arm-linux (with > > PTRACE_GETREGSET and without PTRACE_GETREGSET kernel support respective= ly). > > > > After these patches, arm-linux-nat.c is similar to aarch64-linux-nat.c > > in the aspect of fetching and storing registers. It paves the way for > > multi-arch support in aarch64 gdb (aarch64 gdb can do native debugging > > for arm program), which is the motivation of this patch series. >=20 > I removed " =3D=3D 1" from the condition, as suggested by Doug, and pushed > these patches in. I believe this caused a build regression on i386. After this patch series went in various buildbot i386 buildslaves builds started failing: http://gdb-build.sergiodj.net/waterfall ../../binutils-gdb/gdb/i386-linux-nat.c: In function =E2=80=98fetch_xstater= egs=E2=80=99: ../../binutils-gdb/gdb/i386-linux-nat.c:329:8: error: =E2=80=98have_ptrace_= getregset=E2=80=99 undeclared (first use in this function) ../../binutils-gdb/gdb/i386-linux-nat.c:329:8: note: each undeclared identi= fier is reported only once for each function it appears in ../../binutils-gdb/gdb/i386-linux-nat.c: In function =E2=80=98store_xstater= egs=E2=80=99: ../../binutils-gdb/gdb/i386-linux-nat.c:352:8: error: =E2=80=98have_ptrace_= getregset=E2=80=99 undeclared (first use in this function) make[2]: *** [i386-linux-nat.o] Error 1 Could you take a look? Thanks, Mark