From: Gabriel Krisman Bertazi <gabriel@krisman.be>
To: sergiodj@redhat.com
Cc: palves@redhat.com, gdb-patches@sourceware.org, dje@google.com,
Gabriel Krisman Bertazi <gabriel@krisman.be>
Subject: [PATCH v4 0/4] catch syscall group
Date: Mon, 11 May 2015 00:28:00 -0000 [thread overview]
Message-ID: <1431304069-19647-1-git-send-email-gabriel@krisman.be> (raw)
In-Reply-To: <87wq0gtfxu.fsf@redhat.com>
Thank you both for your review.
This version has the following improvements:
* Apply fixes suggested by Sergio in the testsuite.
* Use xsltproc to generate the xml files.
Regarding the last change, it allowed me to identify inconsistencies in
groups for some architectures. The current design makes sure these
inconsistencies are fixed by centralizing the group information in a
single file.
Also, this patch series *does not* include the generated files because
they are too big and can get in the way of code review. Reviewers must
generate those files by hand by entering the gdb/syscalls directory and
running the makefile there. Build will fail if reviewer don't do this!
Once we get this approved, I'll make sure to include the generated files
in the commit before pushing. Hopefully this will make code review
easier.
Also, I generated this format-patch with --find-renames. If it gets in
the way of git am/git apply, please let me know and I'll resend it.
As usual, I'm not resending the documentation patch again because it was
already approved by Eli.
Thanks!
Gabriel Krisman Bertazi (4):
Implemement support for groups of syscalls in the xml-syscall
interface.
Add support to catch groups of syscalls.
Add tests for catching groups of syscalls on supported
architectures.
Include group information in xml syscall files.
gdb/break-catch-syscall.c | 94 +++++++-
gdb/syscalls/Makefile | 42 ++++
.../{aarch64-linux.xml => aarch64-linux.xml.in} | 0
.../{amd64-linux.xml => amd64-linux.xml.in} | 0
gdb/syscalls/apply-defaults.xsl | 27 +++
gdb/syscalls/{arm-linux.xml => arm-linux.xml.in} | 0
gdb/syscalls/{bfin-linux.xml => bfin-linux.xml.in} | 0
gdb/syscalls/gdb-syscalls.dtd | 3 +-
gdb/syscalls/{i386-linux.xml => i386-linux.xml.in} | 0
gdb/syscalls/linux-defaults.xml.in | 243 +++++++++++++++++++++
.../{mips-n32-linux.xml => mips-n32-linux.xml.in} | 0
.../{mips-n64-linux.xml => mips-n64-linux.xml.in} | 0
.../{mips-o32-linux.xml => mips-o32-linux.xml.in} | 0
gdb/syscalls/{ppc-linux.xml => ppc-linux.xml.in} | 0
.../{ppc64-linux.xml => ppc64-linux.xml.in} | 0
gdb/syscalls/{s390-linux.xml => s390-linux.xml.in} | 0
.../{s390x-linux.xml => s390x-linux.xml.in} | 0
.../{sparc-linux.xml => sparc-linux.xml.in} | 0
.../{sparc64-linux.xml => sparc64-linux.xml.in} | 0
gdb/testsuite/gdb.base/catch-syscall.exp | 39 ++++
gdb/xml-syscall.c | 231 +++++++++++++++++++-
gdb/xml-syscall.h | 16 ++
22 files changed, 683 insertions(+), 12 deletions(-)
create mode 100644 gdb/syscalls/Makefile
rename gdb/syscalls/{aarch64-linux.xml => aarch64-linux.xml.in} (100%)
rename gdb/syscalls/{amd64-linux.xml => amd64-linux.xml.in} (100%)
create mode 100644 gdb/syscalls/apply-defaults.xsl
rename gdb/syscalls/{arm-linux.xml => arm-linux.xml.in} (100%)
rename gdb/syscalls/{bfin-linux.xml => bfin-linux.xml.in} (100%)
rename gdb/syscalls/{i386-linux.xml => i386-linux.xml.in} (100%)
create mode 100644 gdb/syscalls/linux-defaults.xml.in
rename gdb/syscalls/{mips-n32-linux.xml => mips-n32-linux.xml.in} (100%)
rename gdb/syscalls/{mips-n64-linux.xml => mips-n64-linux.xml.in} (100%)
rename gdb/syscalls/{mips-o32-linux.xml => mips-o32-linux.xml.in} (100%)
rename gdb/syscalls/{ppc-linux.xml => ppc-linux.xml.in} (100%)
rename gdb/syscalls/{ppc64-linux.xml => ppc64-linux.xml.in} (100%)
rename gdb/syscalls/{s390-linux.xml => s390-linux.xml.in} (100%)
rename gdb/syscalls/{s390x-linux.xml => s390x-linux.xml.in} (100%)
rename gdb/syscalls/{sparc-linux.xml => sparc-linux.xml.in} (100%)
rename gdb/syscalls/{sparc64-linux.xml => sparc64-linux.xml.in} (100%)
--
2.1.0
next prev parent reply other threads:[~2015-05-11 0:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 1:25 [PATCH v3 00/17] Catch " Gabriel Krisman Bertazi
2015-04-26 1:25 ` [PATCH v3 02/17] Add support to catch groups of syscalls Gabriel Krisman Bertazi
2015-04-26 1:25 ` [PATCH v3 03/17] Add tests for catching groups of syscalls on supported architectures Gabriel Krisman Bertazi
2015-04-26 18:44 ` Sergio Durigan Junior
2015-04-26 1:25 ` [PATCH v3 01/17] Implemement support for groups of syscalls in the xml-syscall interface Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 05/17] Create syscall groups for ppc Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 09/17] Create syscall groups for bfin Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 04/17] Create syscall groups for amd64 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 08/17] Create syscall groups for arm Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 10/17] Create syscall groups for i386 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 06/17] Create syscall groups for ppc64 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 12/17] Create syscall groups for mips-n64 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 07/17] Create syscall groups for aarch64 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 17/17] Create syscall groups for sparc64 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 16/17] Create syscall groups for sparc Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 11/17] Create syscall groups for mips-n32 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 15/17] Create syscall groups for s390x Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 14/17] Create syscall groups for s390 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 13/17] Create syscall groups for mips-o32 Gabriel Krisman Bertazi
2015-04-26 18:58 ` [PATCH v3 00/17] Catch syscall group Sergio Durigan Junior
2015-04-28 11:24 ` Pedro Alves
2015-04-29 0:45 ` Sergio Durigan Junior
2015-04-29 10:44 ` Pedro Alves
2015-05-04 2:34 ` Gabriel Krisman Bertazi
2015-05-06 14:38 ` Pedro Alves
2015-05-10 18:34 ` Gabriel Krisman Bertazi
2015-05-10 19:01 ` Sergio Durigan Junior
2015-05-11 0:28 ` Gabriel Krisman Bertazi [this message]
2015-05-11 0:28 ` [PATCH v4 4/5] Include group information in xml syscall files Gabriel Krisman Bertazi
2015-05-12 21:42 ` Doug Evans
2015-05-13 1:17 ` Gabriel Krisman Bertazi
2015-05-13 10:43 ` Pedro Alves
2015-05-11 0:28 ` [PATCH v4 1/5] Implemement support for groups of syscalls in the xml-syscall interface Gabriel Krisman Bertazi
2015-05-11 0:28 ` [PATCH v4 5/5] Update documentation on catching a group of related syscalls Gabriel Krisman Bertazi
2015-05-11 0:40 ` Gabriel Krisman Bertazi
2015-05-13 10:30 ` Pedro Alves
2015-05-13 16:40 ` Eli Zaretskii
2015-05-11 0:28 ` [PATCH v4 3/5] Add tests for catching groups of syscalls on supported architectures Gabriel Krisman Bertazi
2015-05-11 0:28 ` [PATCH v4 2/5] Add support to catch groups of syscalls Gabriel Krisman Bertazi
2015-05-13 10:38 ` Pedro Alves
2015-05-13 10:47 ` [PATCH v4 0/4] catch syscall group Pedro Alves
2015-05-11 11:39 ` [PATCH v3 00/17] Catch " Pedro Alves
[not found] <001a11c3b928756ec20515e95aba@google.com>
2015-05-12 22:02 ` [PATCH v4 0/4] catch " Sergio Durigan Junior
2015-05-12 22:44 ` Doug Evans
2015-05-12 23:26 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431304069-19647-1-git-send-email-gabriel@krisman.be \
--to=gabriel@krisman.be \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox