Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec

Pedro Alves
2015-04-28T11:31:12Z

On 04/28/2015 12:29 PM, Gary Benson wrote:
> Pedro Alves wrote:

>> We now have at least two places that need to remember to call close.
>> IWBN if we hid that close in a exec_file_find variant, so that
>> callers didn't have to recall to do it. Maybe rename exec_file_find
>> to (e.g.) exec_file_find_fd and reuse the exec_file_find name, even.
>
> Good shout. How about I fix solib_find_1 to accept fd == NULL, and
> put the closing logic in there? That

Sounds good.

> would work for solib_find too then (I'm not sure if there are
> any "solib_find; close" places in GDB but I'll look.)

Thanks,
Pedro Alves