Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec

Pedro Alves
2015-04-27T15:59:55Z

On 04/17/2015 02:28 PM, Gary Benson wrote:
> Hi all,
>
> This commit updates follow_exec to use exec_file_find to prefix
> the new executable's filename with gdb_sysroot rather than doing
> it longhand.
>
> Built and regtested on RHEL6.6 x86_64.
>
> Ok to commit?

OK.

> - if (gdb_sysroot && *gdb_sysroot)
> + if (gdb_sysroot != NULL && *gdb_sysroot != '\0')
> {
> - char *name = alloca (strlen (gdb_sysroot)
> - + strlen (execd_pathname)
> - + 1);
> + int fd = -1;
> + char *name;
>
> - strcpy (name, gdb_sysroot);
> - strcat (name, execd_pathname);
> - execd_pathname = name;
> + name = exec_file_find (execd_pathname, &fd);
> + if (fd >= 0)
> + close (fd);

We now have at least two places that need to remember to call
close. IWBN if we hid that close in a exec_file_find variant, so
that callers didn't have to recall to do it. Maybe
rename exec_file_find to (e.g.) exec_file_find_fd and reuse
the exec_file_find name, even.

Thanks,
Pedro Alves