From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 05/24] Don't rely on inferior I/O in {call-signal-resume, unwindonsignal}.exp
Date: Tue, 21 Apr 2015 18:09:00 -0000 [thread overview]
Message-ID: <1429639711-16459-6-git-send-email-palves@redhat.com> (raw)
In-Reply-To: <1429639711-16459-1-git-send-email-palves@redhat.com>
These tests rely on inferior I/O, but that seems pointless and
unrelated here. Simply remove the printf calls, and don't expect
them.
gdb/testsuite/ChangeLog:
2015-04-21 Pedro Alves <palves@redhat.com>
* gdb.base/call-signal-resume.exp: Remove check for
gdb,noinferiorio. Don't expect "no signal". Use gdb_test.
* gdb.base/unwindonsignal.exp: Likewise.
* gdb.base/call-signals.c (gen_signal): Remove printf call.
* gdb.base/unwindonsignal.c (gen_signal): Likewise.
---
gdb/testsuite/gdb.base/call-signal-resume.exp | 18 ++++--------------
gdb/testsuite/gdb.base/call-signals.c | 3 ---
gdb/testsuite/gdb.base/unwindonsignal.c | 3 ---
gdb/testsuite/gdb.base/unwindonsignal.exp | 18 ++++--------------
4 files changed, 8 insertions(+), 34 deletions(-)
diff --git a/gdb/testsuite/gdb.base/call-signal-resume.exp b/gdb/testsuite/gdb.base/call-signal-resume.exp
index a4e6bd0..a8b0585 100644
--- a/gdb/testsuite/gdb.base/call-signal-resume.exp
+++ b/gdb/testsuite/gdb.base/call-signal-resume.exp
@@ -20,11 +20,6 @@
# 2) Inferior is stopped at a signal. Upon resumption it should continue
# with that signal, regardless of whatever the hand-called function did.
-if [target_info exists gdb,noinferiorio] {
- verbose "Skipping call-signal-resume.exp because of no fileio capabilities."
- continue
-}
-
if [target_info exists gdb,nosignals] {
verbose "Skipping call-signal-resume.exp because of nosignals."
continue
@@ -72,15 +67,10 @@ gdb_test "continue" "Continuing.*Breakpoint \[0-9\]*, stop_one.*" \
# Call function (causing the program to get a signal), and see if gdb handles
# it properly.
-gdb_test_multiple "call gen_signal ()" \
- "inferior function call signaled" {
- -re "\[\r\n\]*no signal\[\r\n\]+$gdb_prompt $" {
- unsupported "inferior function call signaled"
- return 0
- }
- -re "\[\r\n\]*The program being debugged was signaled.*\[\r\n\]+$gdb_prompt $" {
- pass "inferior function call signaled"
- }
+if {[gdb_test "call gen_signal ()" \
+ "\[\r\n\]*The program being debugged was signaled.*" \
+ "inferior function call signaled"] != 0} {
+ return 0
}
set frame_number [get_dummy_frame_number]
diff --git a/gdb/testsuite/gdb.base/call-signals.c b/gdb/testsuite/gdb.base/call-signals.c
index 2c5b770..c166649 100644
--- a/gdb/testsuite/gdb.base/call-signals.c
+++ b/gdb/testsuite/gdb.base/call-signals.c
@@ -18,7 +18,6 @@
/* Support program for testing handling of inferior function calls
in the presence of signals. */
-#include <stdio.h>
#include <signal.h>
#include <unistd.h>
@@ -32,8 +31,6 @@ gen_signal ()
{
/* According to sigall.exp, SIGABRT is always supported. */
kill (getpid (), SIGABRT);
- /* If we get here we couldn't generate a signal, tell dejagnu. */
- printf ("no signal\n");
}
/* Easy place to set a breakpoint. */
diff --git a/gdb/testsuite/gdb.base/unwindonsignal.c b/gdb/testsuite/gdb.base/unwindonsignal.c
index 92d8ba4..e1b2094 100644
--- a/gdb/testsuite/gdb.base/unwindonsignal.c
+++ b/gdb/testsuite/gdb.base/unwindonsignal.c
@@ -17,7 +17,6 @@
/* Support program for testing unwindonsignal. */
-#include <stdio.h>
#include <signal.h>
#include <unistd.h>
@@ -26,8 +25,6 @@ gen_signal ()
{
/* According to sigall.exp, SIGABRT is always supported. */
kill (getpid (), SIGABRT);
- /* If we get here we couldn't generate a signal, tell dejagnu. */
- printf ("no signal\n");
}
/* Easy place to set a breakpoint. */
diff --git a/gdb/testsuite/gdb.base/unwindonsignal.exp b/gdb/testsuite/gdb.base/unwindonsignal.exp
index 2014e8d..dd53cfe 100644
--- a/gdb/testsuite/gdb.base/unwindonsignal.exp
+++ b/gdb/testsuite/gdb.base/unwindonsignal.exp
@@ -13,11 +13,6 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-if [target_info exists gdb,noinferiorio] {
- verbose "Skipping unwindonsignal.exp because of no fileio capabilities."
- continue
-}
-
if [target_info exists gdb,nosignals] {
verbose "Skipping unwindonsignal.exp because of nosignals."
continue
@@ -58,15 +53,10 @@ gdb_test "show unwindonsignal" \
# Call function (causing the program to get a signal), and see if gdb handles
# it properly.
-gdb_test_multiple "call gen_signal ()" \
- "unwindonsignal, inferior function call signaled" {
- -re "\[\r\n\]*no signal\[\r\n\]+$gdb_prompt $" {
- unsupported "unwindonsignal, inferior function call signaled"
- return 0
- }
- -re "\[\r\n\]*The program being debugged was signaled.*\[\r\n\]+$gdb_prompt $" {
- pass "unwindonsignal, inferior function call signaled"
- }
+if {[gdb_test "call gen_signal ()" \
+ "\[\r\n\]*The program being debugged was signaled.*" \
+ "unwindonsignal, inferior function call signaled"] != 0} {
+ return 0
}
# Verify the stack got unwound.
--
1.9.3
next prev parent reply other threads:[~2015-04-21 18:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 18:08 [PATCH 00/24] Remove gdb,noinferiorio from gdbserver boards Pedro Alves
2015-04-21 18:08 ` [PATCH 07/24] Introduce gdb_test_stdio Pedro Alves
2015-04-21 18:08 ` [PATCH 10/24] Make gdb.base/catch-gdb-caused-signals.exp use gdb_test_stdio Pedro Alves
2015-04-21 18:08 ` [PATCH 16/24] Make gdb.base/shlib-call.exp " Pedro Alves
2015-04-21 18:08 ` [PATCH 04/24] Don't rely on inferior I/O in gdb.base/siginfo-addr.exp Pedro Alves
2015-04-21 18:08 ` [PATCH 01/24] gdb_test_multiple match eof of any spawn_id Pedro Alves
2015-04-21 18:08 ` [PATCH 12/24] Make gdb.base/a2-run.exp use $inferior_spawn_id and gdb_test_stdio Pedro Alves
2015-04-21 18:08 ` [PATCH 13/24] Make gdb.base/call-ar-st.exp use gdb_test_stdio Pedro Alves
2015-04-21 18:09 ` [PATCH 20/24] Adjust MI to $inferior_spawn_id Pedro Alves
2015-04-21 18:09 ` [PATCH 17/24] Make gdb.base/varargs.exp use gdb_test_stdio Pedro Alves
2015-04-21 18:09 ` [PATCH 09/24] Make gdb.base/call-strs.exp " Pedro Alves
2015-04-21 18:09 ` [PATCH 14/24] Make gdb.base/call-rt-st.exp use $inferior_spawn_id Pedro Alves
2015-04-21 18:09 ` [PATCH 06/24] Don't rely on inferior I/O in gdb.base/restore.exp Pedro Alves
2015-04-21 18:09 ` [PATCH 03/24] Fix gdb.base/interrupt.exp racy fail against gdbserver Pedro Alves
2015-04-23 14:28 ` Yao Qi
2015-04-23 14:58 ` Pedro Alves
2015-04-21 18:09 ` [PATCH 22/24] Unbuffer all tests that rely on stdio Pedro Alves
2015-04-21 18:09 ` [PATCH 11/24] Make gdb.base/dprintf.exp use gdb_test_stdio Pedro Alves
2015-04-21 18:09 ` [PATCH 19/24] Make gdb.gdb/selftest.exp use '-i $inferior_spawn_id' Pedro Alves
2015-04-21 18:09 ` [PATCH 24/24] Don't set gdb,noinferiorio on gdbserver boards Pedro Alves
2015-04-23 15:09 ` Yao Qi
2015-04-23 15:24 ` Pedro Alves
2015-04-24 9:19 ` Yao Qi
2015-04-21 18:09 ` [PATCH 23/24] interrupt.exp: Revert back to checking gdb,noinferiorio at the top Pedro Alves
2015-04-21 18:09 ` [PATCH 02/24] gdb.base/interrupt.exp: Rename saw_eof to saw_end_of_file Pedro Alves
2015-04-21 18:09 ` Pedro Alves [this message]
2015-04-21 18:09 ` [PATCH 21/24] Make gdb.mi/mi-dprintf.exp use $inferior_spawn_id Pedro Alves
2015-04-21 18:15 ` [PATCH 08/24] Make gdb.base/sizeof.exp use gdb_test_stdio Pedro Alves
2015-04-23 15:36 ` Antoine Tremblay
2015-04-23 15:38 ` Antoine Tremblay
2015-04-23 15:49 ` Pedro Alves
2015-04-23 16:04 ` Pedro Alves
2015-04-23 16:25 ` Antoine Tremblay
2015-04-21 18:18 ` [PATCH 18/24] Make gdb.gdb/complaints.exp use '-i $inferior_spawn_id' and gdb_test_stdio Pedro Alves
2015-04-21 18:43 ` [PATCH 15/24] Make gdb.base/ending-run.exp use gdb_test_stdio Pedro Alves
2015-07-29 11:41 ` [PATCH 00/24] Remove gdb,noinferiorio from gdbserver boards Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429639711-16459-6-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox