Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: gdb-patches@sourceware.org
Cc: Maxim Grigoriev <maxim2405@gmail.com>,
	Woody LaRue <larue@cadence.com>,	Marc Gauthier <marc@cadence.com>,
	linux-xtensa@linux-xtensa.org,	Pedro Alves <palves@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH] gdb: fix xtensa build with custom overlay
Date: Fri, 17 Apr 2015 16:12:00 -0000	[thread overview]
Message-ID: <1429287116-20216-1-git-send-email-jcmvbkbc@gmail.com> (raw)

The commit 14e361d7aa3bbd8601b0457ee8558344e444c651 ("xtensa-config.c:
missing defs.h include") fixed the build of default xtensa configuration
by including defs.h in the beginning of xtensa-config.c. Unfortunately
this fix doesn't work when gdb is configured for another xtensa core, as
the file xtensa-config.c is a part of configuration overlay and it gets
overwritten. To fix the build for all existing configurations include
defs.h into gdb/xtensa-tdep.h, where the issue (reference to undeclared
uint32_t) actually is.

2015-04-17  Max Filippov  <jcmvbkbc@gmail.com>
gdb/
	* xtensa-tdep.h: Include defs.h
---
 gdb/xtensa-tdep.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/xtensa-tdep.h b/gdb/xtensa-tdep.h
index adacaf8..4ebe6de 100644
--- a/gdb/xtensa-tdep.h
+++ b/gdb/xtensa-tdep.h
@@ -21,6 +21,8 @@
 /* XTENSA_TDEP_VERSION can/should be changed along with XTENSA_CONFIG_VERSION
    whenever the "tdep" structure changes in an incompatible way.  */
 
+#include "defs.h"
+
 #define XTENSA_TDEP_VERSION 0x60
 
 /*  Xtensa register type.  */
-- 
1.8.1.4


             reply	other threads:[~2015-04-17 16:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 16:12 Max Filippov [this message]
2015-04-17 16:21 ` Pedro Alves
2015-04-17 16:46   ` Max Filippov
2015-04-17 17:24     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429287116-20216-1-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=larue@cadence.com \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=marc@cadence.com \
    --cc=maxim2405@gmail.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox