Re: [PATCH v7 1/7] Identify remote fork event support

Pedro Alves
2015-04-15T15:37:52Z

On 04/10/2015 06:09 PM, Don Breazeal wrote:
> @@ -6469,4 +6487,7 @@ initialize_low (void)
> sigaction (SIGCHLD, &sigchld_action, NULL);
>
> initialize_low_arch ();
> +
> + /* Enable extended ptrace events. */
> + linux_check_ptrace_features ();

I think the comment might have made sense possibly in a earlier revision
that added to additional ptrace options, but it looks a bit strange
now, as this isn't enabling the features yet, just checking what is
supported. A comment like

/* Check supported ptrace features. */

would just repeat the function's signature, so I'd suggest just
dropping the comment.

Otherwise OK.

Thanks,
Pedro Alves