Re: [PATCH 3/4] Implement support for checking /proc/PID/coredump_filter

Pedro Alves
2015-03-19T10:41:49Z

On 03/18/2015 07:38 PM, Sergio Durigan Junior wrote:
> + /* If a mapping should not be dumped we still should create
> + a segment for it, just without SEC_LOAD (see
> + gcore_create_callback). */

I think this comment is stale now?

> + if (has_anonymous)
> + {
> + if (dump_mapping_p (filterflags, &v, private, mapping_anon_p,
> + filename))
> + modified_state = MEMORY_MAPPING_MODIFIED;
> + else
> + modified_state = MEMORY_MAPPING_UNMODIFIED;
> + }
> + else
> + {
> + /* Older Linux kernels did not support the "Anonymous:" counter.
> + If it is missing, we can't be sure - dump all the pages. */
> + modified_state = MEMORY_MAPPING_UNKNOWN_STATE;
> + }

Thanks,
Pedro Alves