From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iFY5BhNDRWWs8j0AWB0awg (envelope-from ) for ; Fri, 03 Nov 2023 14:59:31 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=p0FNaduf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 153E11E1A7; Fri, 3 Nov 2023 14:59:31 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 02C1A1E0D2 for ; Fri, 3 Nov 2023 14:59:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41F23385841A for ; Fri, 3 Nov 2023 18:59:28 +0000 (GMT) Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2045.outbound.protection.outlook.com [40.107.116.45]) by sourceware.org (Postfix) with ESMTPS id 1BF7E3858D28 for ; Fri, 3 Nov 2023 18:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BF7E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BF7E3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.45 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699037957; cv=pass; b=apNEeU6XJHK00ubyponLAHUGz1oSGGIPN2YAUOHTxXWXJXF3tcaF0MMpgWWNHra73OBqbgga3v5IJd91u18wv/WCJ+3SO9Bi+GqPGO4/jCsR1vJ83WwKCPs7b1K5CRvxrl/5e8ibmExYHc4wOezYHBqoQ+dzvn+ulBk+t6TWi7s= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699037957; c=relaxed/simple; bh=cm65mmhuAwv3J8HimYx8thh2FUyHXZ1J9zajJjIdmlg=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=vdU+yAUlvC9pVMbk1TDvd+RTe8o8LdL5wPOHIvjsu4IbHLwMIY8fBclTLRSo0m2XB6N/2bYb2vcZV62APEO7OUHrDwEZL3q6oPex5uIq0em8rQ9j6msenrcZrO7IydH3wiXGeB7BJDW8YfUt0pMnpTu+WJbjrlqDrHEk0WLpE+o= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7v1ozVw+PGprY0188tEY+6EHAGWVIIlMSYEXLtm5sm6ewoecivkMwoZeW6zvHg+nvck7L5eK5JExJDpPPVEjwHgP8s5qMHyuqzXVUuPNLaAMEB3/QFOG2zW9nrx7TA3eNHSJgXyknIGOINHiSVoeQehw2ggxtiOXtqs6BX4S6dBoWCHlUOsj7a2UxQsjiM4t3XqkQzLtWZrgf8xNeXTBaN8KpLBo5Bm6gJc5jo85Oe23NtPKzRiaiaBjrgMGXloewDZDoiiA/xEICkpM437r4OZNcZQJRTG72WxCdSNTHBWtV2THOtD3lOIzkuMYPuNtDKH1WvcuXuHo0LHiQLVmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5u/56E6FJVLDOk0mUQkPo5BTOvltRmV8OZZQyTcjbA=; b=OEZIxDT5pbDFvmmRdpC3XLJ6cwIINcIxRaVempmzVm5j1vT2f5pKhP+A239UL6JUqBJmyxfopJMGYSpx8OpIj2iqX70MpxRYqU0WsPdJ/oLDNhLhyGyj8ycZ2FNHAYKAAU0q4aTb99M8yqK5CswtQqZ7kntKvlRSl5L7li7D3GKVDW/fmkZOFRMdm1Mab+ZssStwlruf1MyeH1fwsqJ2kxSDIMBR3XlaQtFZiAKV79BAb8vggkTMMZWSQGcpHiLdcCEqaXMql/SOsgnXblHuBb4oiIRlyGfKOCtnGm7Y8XklBPNAy6vG7byUCaIkvmlQqVeiLDnVRzEQ1qIh3O94YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a5u/56E6FJVLDOk0mUQkPo5BTOvltRmV8OZZQyTcjbA=; b=p0FNadufZcvrkbICiziZ9fM32HB4aP+cwpzuu/uWuwwJlUBotRRwoPqcTsCgmWMrD5/+fm1BLXdksBI/1XGNzCIgs8z88joPwGJeQODW7oykt9CTTm7SEv9WGs2b1keL3zbYNfokkLd/FQNoozlP9YFRjYi7gkOx/lay4Rc107Y5pIhgI2lb7nf/CqNTF2I8b6nhhN6okYtBqs5E8wEvKqJ0+Vm8B3IRhHrRM7Ygd+U0qrG3fmTE/sYXERpfdn+C0ye4wmqADsXPiR5aytOhLzq+Di84zpbE6deCLrYuNI/vSBmcJYQAwFJWZ73dINEc4HFkOtEMDFJbyCrFMyPreg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB8659.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:78::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.24; Fri, 3 Nov 2023 18:59:05 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::1db5:8518:3589:61aa]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::1db5:8518:3589:61aa%4]) with mapi id 15.20.6954.021; Fri, 3 Nov 2023 18:59:05 +0000 Message-ID: <14263d5d-68c3-4da1-8a3f-d1437188f4f1@efficios.com> Date: Fri, 3 Nov 2023 14:59:03 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport: mark array_view::slice with [[nodiscard]] Content-Language: fr To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20231103031917.927026-1-simon.marchi@polymtl.ca> <87y1feiu3n.fsf@tromey.com> <87lebeit5o.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87lebeit5o.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0354.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6b::11) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB8659:EE_ X-MS-Office365-Filtering-Correlation-Id: ab8441c3-2dc1-4db4-5b53-08dbdc9ef370 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GELMl+dZ6IwkYX2hmrXHoOfLdD6yvbSCuIzlN1r2lpro8hHMUFfF9HfJkpa/vl/7AUo8F0lQ1Y8RETeaD4+V3dh3kTgk4WVE/Gd0h7TcgUZmg+XWGMGl+4007sxf/okfaErIkCa68dW+eWRFplKwbSsGe9/b8vF32R2/+C3JCn5iMln4DJImyx5uAFOBRxPyUYmXiT7xW/mC0jaV0ySKGFaKBPBYnwIzShi7c+STxoujbiEtzKJk2GLG3h9bVnOak+ifWrXVvgrjy03QEX3meXB1nEgcbvYFUcZn81SvvfRAIDGF3AjK9Be1mwrN5HztICUJVkNowvB664LcrzxyKZVC+SpX890suNT4BIl+CZaL/KqYK0hRZHrcUy4POC5h3nOCvA8rpytAz9QSz34yxx/zWav5+DmJYoW748lBJRkHzSBYOKdLgSaDflQ2DD/QP3EUz/Zt8Jmk6KC5KG91DeIMEH3xXkhqhzHbJXwPrIzrXNQc/2LWIeZXhLdiwi6zglUwwNY9/bDOY6ukwhuaD1q2tlpZYE9i0t8yJ/zi70GDWzRToAPTM09gPYnNqViFYEBuWWRgB5aoqnM33621NA2XF5gGFA5CwdcYxaIMI/dQK2Nw3Iw4Zb0jbO2he9xvc6AaRj5XuLCKUmL3O57zh5ofmkjnrDv9mEh6ydM378bO8VWE4aeVfzm6AwvULumv X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(346002)(39830400003)(376002)(366004)(230922051799003)(230173577357003)(230273577357003)(64100799003)(451199024)(1800799009)(186009)(38100700002)(31686004)(83380400001)(8936002)(8676002)(4326008)(2906002)(41300700001)(44832011)(31696002)(5660300002)(6916009)(4744005)(316002)(66556008)(66476007)(6486002)(478600001)(6512007)(36756003)(66946007)(6506007)(53546011)(26005)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTB1Ulh4SUFmdlRvRmVTT3FjeTJHNnNMZkJCSkdZd2V1SUQ4b1dkVlAyZU9o?= =?utf-8?B?MjhaZUF2YXpwUFdIcllaNU5PZTFtT0hwVTdZa3pDaElQek5jU3RLSjhjUjJs?= =?utf-8?B?ZTBvZXhyUWxjL200L29WWDBmRW9VYUIxQ2NNZWFQcVlxZjFsb0tJMlpsa3BJ?= =?utf-8?B?VTdYQlRWeXNjRWtLSFZRRSsyb3VkbFlPdUdBT2FYUnd2ZjVjSjNsRWNhbGVw?= =?utf-8?B?b21KamxaKzdrbHRTQjhHL252RDdrL2k1bUFKZlVaczA4TjFwT3lFQmpMb3dp?= =?utf-8?B?dWk2MTNmaWJhWUdLMEg4Tyt2bkxxbHM3cDlFTGdzckxNUWRabWptMlZxaWRu?= =?utf-8?B?TTkxb3pmQnU4cGY4SWpkeU00emtkQnBRZkdDWTBtdlZPVVhQZTJpUkwrNUxz?= =?utf-8?B?RGVNVXl4MVUzZEJqVTNGajZOd3o4SVEyRmVNcXVQdzNPeFQyQmdVY1QzQ3Ri?= =?utf-8?B?Ym84V2FzRzZ0SWZldHVpOHJ3RERmNG1qZDdPUEVNT0JpN2JpWEZuRkNrejlP?= =?utf-8?B?encrU3NDZmdDb2xVWFlib2NSbFFZS0lVeklkYXJHa213aGJPMHk3eURxQ2ts?= =?utf-8?B?KzFSbmNYZmpwazNLSVdvK0VsZnlQcWQ2QXdudWRObjgzTDZiS2tna3M3YzBC?= =?utf-8?B?VTlFT0VQM2g3R2NWNlZ0QjFOVWRuMnM4RXlQSGlXYStYbkJyRm1taXREUjBh?= =?utf-8?B?NnFINnU1alNHRkUya2xITTdxd29rN1JvdWpIWTc3NXZmNFFHdVE1c2wzQ0ZQ?= =?utf-8?B?R3paMkhPekdOay9haWM5aXk3dVo5NXJEallNN2FwNndnanU4N2ZidExRdnp4?= =?utf-8?B?aTFVK0M3Q1BGSkRqbGQ4clNQay9JQ0pZVWxBYXFlN1o2Q08rRysrd3RGakpv?= =?utf-8?B?RkFxckgwVVBET21PQUFLZ3VZOTE0emU0dmRMMTdFNFZLblpTU1hlaFBBWHNX?= =?utf-8?B?aW5GbWMzTW5XU3FHOTFLZVhSQXQ0dUxYalpmUUdmSkh2UUQwcmptYWh3eHhh?= =?utf-8?B?NEhNYzNKbnp2WitZRGNZTytBeUxCVzVBNmZUMnBmSEJTK1RiVjk3VW9QL3JX?= =?utf-8?B?c3ZXNkw4eEFUaWJ2T0ZhZGlBbUt5UXJUOUwyUU1NQ0hWR0JyK25MT21va0da?= =?utf-8?B?bGIyZ3FHU1VBTDJqZXFYSStndm1DSGpmZGxHaWplUWlndm9KRDB2NlNDQUFT?= =?utf-8?B?U1E2Vy9iZitwVkcvVmtUak9oV3RnWm1pTGNwOHVoSTZGdWtjZjdydFhQMnlq?= =?utf-8?B?dTIwRE84MUY2SzlaN1ZMRGRkNkU3RjArRFBydlNUb01FcVBLTVMwdERzOEhx?= =?utf-8?B?eFpUalMzbnFvZnBySktmK2JYTDhGNmMrNm50YVpJU3VNeUpPaWZ6aU9ENGI2?= =?utf-8?B?UnNOYk8vL0twczF2Y2ZabTZyL0tMRGpBYXRHSXNPU3poUzdsRFZzdGxmZW82?= =?utf-8?B?REN4WUFKTklvUCtFUWtlZ21CWmN5Mk14ZTJ2RW81S09yZTlUd1lKc0FGZ1Ra?= =?utf-8?B?SFhtd2hLamVpekpGQ1VGcFZDNW9yZ0JRS1I0RXRKVFNIVUpjM05qcXUwVzh6?= =?utf-8?B?UWNOMG8ySTJwWTJTWG9ObnR4Ukd5MWlvb0FmSVljOGtwK0lrZFNtejhtSFkz?= =?utf-8?B?dVRBQmdXbHRvSkZkMGxaSjUwUGplYkpFTXFaRnZUQkpIcXl5RnI5KytIcGI0?= =?utf-8?B?SlFYSXNVSUFGNnpSV1VqSDRjVmt4bFhId1pJSDd5bXF6emIyR3VzU1pYUEFt?= =?utf-8?B?aGpiT2s1MlhxTnJHNWNEdHVIeEQxUUt6cjFxemYvRkVNN3NQZktWV3ZlVUd6?= =?utf-8?B?SEhqdEg4U0UwYWNvZ3F1aGVSUEtFQmFZbjJIZlNzZkNYME9YSjZiRzc5ZStB?= =?utf-8?B?MEZQejRBWHhxY0kxWTNoZGRreEFpZHdJMENBeWd5UldEbzhxWWhkbUhOc0pZ?= =?utf-8?B?aE53dnpORStrSGphZ2tkd2xBQWFITXBJdFV0Wkh4ZUdjYVh3eDl6Qk9uRUZ2?= =?utf-8?B?VDVCQmVTOGVnL01xZG1FY3VDSzVQZDhVZHRQYjZ3YTlaVHZ6VUlwcDAwSURT?= =?utf-8?B?Z29nMXBCampic2VaRUY4WW9qVUNYRGxYMi8vU0xwT2tQVDY2TGgyWUdFcml0?= =?utf-8?Q?Fl+mniE6YZdKnrKbLJFjHls6k?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab8441c3-2dc1-4db4-5b53-08dbdc9ef370 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 18:59:05.1296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OPqUG9Wp4ncZPsDwwYTlvA30MRyP9tkBnyyPbDOTlHFxH3fmXcmH08SfhXKhIk8As9OHQN3QJ1N9/PalgF9N+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8659 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 11/3/23 14:33, Tom Tromey wrote: >>> Unfortunately std::span::subspan doesn't seem to have this annotation. >>> I wonder if it could be added. > > Simon> Is it something that would be mandated by the standard, or just the > Simon> choice of each implementation? > > I asked Jonathan Wakely on irc and he said he'll add it to libstdc++. Wow, thanks a lot for doing that. > The standard does sometimes specify [[nodiscard]], but he said that he > has been campaigning against that, because implementations are already > free to add it anywhere (they can emit any warnings they like) and they > are also free to ignore any annotation. So specifying it is pointless. I think that makes sense to not specify them, they don't have an impact on how the program behave. Simon