Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Make "set scheduler-locking step" depend on user intention, only
Date: Wed, 11 Mar 2015 14:40:00 -0000	[thread overview]
Message-ID: <1426084798-1032-1-git-send-email-palves@redhat.com> (raw)

Currently, "set scheduler-locking step" is a bit odd.  The manual
documents it as being optimized for stepping, so that focus of
debugging does not change unexpectedly, but then it says that
sometimes other threads may run, and thus focus may indeed change
unexpectedly...  A user can then be excused to get confused and wonder
why does GDB behave like this.

I don't think a user should have to know about details of how "next"
or whatever other run control command is implemented internally to
understand when does the "scheduler-locking step" setting take effect.

Thus this series makes "set scheduler-locking step" hold threads
depending on whether the _command_ the user entered was a stepping
command [step/stepi/next/nexti], or not.  More details in patch #3.

The rest of the series is related groundwork and cleaning up.

Tested on x86_64 Fedora 20, native and gdbserver.

Pedro Alves (4):
  No longer handle negative 'step' in 'proceed'
  Make step_start_function be per thread
  Make "set scheduler-locking step" depend on user intention, only
  Remove 'step' parameters from 'proceed' and 'resume'

 gdb/breakpoint.c                        |   2 +-
 gdb/doc/gdb.texinfo                     |   5 +-
 gdb/gdbthread.h                         |   8 ++
 gdb/infcall.c                           |   2 +-
 gdb/infcmd.c                            |  38 +++++----
 gdb/infrun.c                            | 139 ++++++++++++++++----------------
 gdb/infrun.h                            |   4 +-
 gdb/mi/mi-main.c                        |   2 +-
 gdb/testsuite/gdb.threads/schedlock.exp |  11 ++-
 gdb/windows-nat.c                       |   2 +-
 10 files changed, 114 insertions(+), 99 deletions(-)

-- 
1.9.3


             reply	other threads:[~2015-03-11 14:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 14:40 Pedro Alves [this message]
2015-03-11 14:40 ` [PATCH 4/4] Remove 'step' parameters from 'proceed' and 'resume' Pedro Alves
2015-03-11 14:40 ` [PATCH 2/4] Make step_start_function be per thread Pedro Alves
2015-03-11 14:40 ` [PATCH 3/4] Make "set scheduler-locking step" depend on user intention, only Pedro Alves
2015-03-18 20:06   ` Pedro Alves
2015-03-18 20:22     ` Eli Zaretskii
2015-10-22  7:21   ` Jan Kratochvil
2015-03-11 14:40 ` [PATCH 1/4] No longer handle negative 'step' in 'proceed' Pedro Alves
2015-03-24 18:07 ` [PATCH 0/4] Make "set scheduler-locking step" depend on user intention, only Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426084798-1032-1-git-send-email-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox