From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69586 invoked by alias); 5 Mar 2015 23:42:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69516 invoked by uid 89); 5 Mar 2015 23:42:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Mar 2015 23:42:54 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t25Ngqk0001592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Mar 2015 18:42:53 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t25Ngng3017305 for ; Thu, 5 Mar 2015 18:42:52 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [pushed 2/2] gdb.base/bp-permanent.exp: Tighten regex Date: Thu, 05 Mar 2015 23:42:00 -0000 Message-Id: <1425598969-7666-3-git-send-email-palves@redhat.com> In-Reply-To: <1425598969-7666-1-git-send-email-palves@redhat.com> References: <1425598969-7666-1-git-send-email-palves@redhat.com> X-SW-Source: 2015-03/txt/msg00168.txt.bz2 Trying to fix a permanent breakpoints bug, I broke "next" over a regular breakpoint. "next" would immediately hit the breakpoint the program was already stopped at. But, the "next over setup" test failed to notice this and still issued a pass. That's because the regex matches "testsuite" in: Breakpoint 2 at 0x400687: file src/gdb/testsuite/gdb.base/bp-permanent.c, line 46. gdb/testsuite/ChangeLog: 2015-03-05 Pedro Alves * gdb.base/bp-permanent.exp: Tighten "next over setup" regex. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/bp-permanent.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1a76cc8..dd98483 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2015-03-05 Pedro Alves + + * gdb.base/bp-permanent.exp: Tighten "next over setup" regex. + 2015-03-04 Simon Marchi * lib/mi-support.exp (mi_expect_interrupt): Accept diff --git a/gdb/testsuite/gdb.base/bp-permanent.exp b/gdb/testsuite/gdb.base/bp-permanent.exp index d0ed991..81a5293 100644 --- a/gdb/testsuite/gdb.base/bp-permanent.exp +++ b/gdb/testsuite/gdb.base/bp-permanent.exp @@ -96,7 +96,7 @@ proc test {always_inserted sw_watchpoint} { # Run the "setup" function in the inferior. This memcpy's the # breakpoint instruction to a buffer in the inferior. - gdb_test "next" "test.*" "next over setup" + gdb_test "next" "test_basics \\(\\).*" "next over setup" delete_breakpoints -- 1.9.3