From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17503 invoked by alias); 19 Feb 2015 00:48:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17490 invoked by uid 89); 19 Feb 2015 00:48:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Feb 2015 00:48:52 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 8B07A31DCB943; Thu, 19 Feb 2015 00:48:45 +0000 (GMT) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 19 Feb 2015 00:48:49 +0000 Received: from [10.20.3.58] (10.20.3.58) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 18 Feb 2015 16:48:36 -0800 Message-ID: <1424306916.27855.115.camel@ubuntu-sellcey> Subject: Re: Build failure with probe patch From: Steve Ellcey Reply-To: To: Sergio Durigan Junior CC: , Date: Thu, 19 Feb 2015 00:48:00 -0000 In-Reply-To: <87wq3ercw0.fsf@redhat.com> References: <87wq3ercw0.fsf@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2015-02/txt/msg00509.txt.bz2 On Wed, 2015-02-18 at 18:57 -0500, Sergio Durigan Junior wrote: > On Wednesday, February 18 2015, Steve Ellcey wrote: > > > Is anyone else seeing this error when building the top-of-tree gdb: > > > > > > cc1: warnings being treated as errors > > /scratch/sellcey/gdb-bug/src/gdb/gdb/dtrace-probe.c: In function 'dtrace_get_probes': > > /scratch/sellcey/gdb-bug/src/gdb/gdb/dtrace-probe.c:624: warning: dereferencing type-punned pointer will break strict-aliasing rules > > make[1]: *** [dtrace-probe.o] Error 1 > > Thanks for your report. > > I don't see anything like this in any of our builders here: > > > > > I get this when building gdb on a CentOS 5 system with GCC 4.1.2 but I do not > > see it when building on a Ubuntu 12.04 system with GCC 4.6.3. I am not sure > > if this is due to the old GCC or if it is a legitimate error. > > According to: > > > > This warning has been removed from GCC. And by looking at the code > referenced by it, I don't see anything wrong there. So I'd say you can > ignore this (and probably update your GCC). > I would like to avoid updating GCC if possible. I build on old systems because some of our customers use old systems. I don't know if gdb has a 'minimal GCC' that it can be compiled with like GCC and some other projects have. I tried changing the definition of 'dof' to be ' bfd_byte *' instead of 'struct dtrace_dof_hdr *' and then casting it on the call to dtrace_process_dof instead of the call to bfd_malloc_and_get_section. That got rid of the type punning message but I wound up seeing: /scratch/gcc/nightly/src/binutils-gdb/gdb/dtrace-probe.c: In function 'dtrace_get_probes': /scratch/gcc/nightly/src/binutils-gdb/gdb/dtrace-probe.c:64: warning: 'arg.expr' is used uninitialized in this function make[1]: *** [dtrace-probe.o] Error 1 Which I do not understand at all. I will investigate some more and see if there is a clean way to get this to compile with GCC 4.1.2. Steve Ellcey sellcey@imgtec.com