Re: [PATCH v3 04/15] record btrace: add configuration struct

Eli Zaretskii
2015-01-29T17:11:15Z

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 29 Jan 2015 17:28:08 +0100
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -14,6 +14,17 @@
> * The command 'thread apply all' can now support new option '-ascending'
> to call its specified command for all threads in ascending order.
>
> +* New commands
> +
> +record btrace bts
> +record bts
> + Start branch trace recording using Intel(R) Branch Trace Store format.
> +
> +* New remote packets
> +
> +qXfer:btrace-conf:read
> + Return the branch trace configuration for the current thread.
> +
> *** Changes in GDB 7.9

This part is OK.

> +@table @code
> +@item bts
> +Use Intel's Branch Trace Store (BTS) recording format. In this format,
> +the processor stores a from/to record for each executed branch in the
> +btrace ring buffer.

Please us @dfn{...} around "Branch Trace Store" (it's new
terminology), and please use "@acronym{BTS}".

Also, please add a @cindex entry for "branch trace store" here.

The documentation parts are OK with these fixed.

Thanks.