RE: [PATCH v3 00/15] record btrace: prepare for a new trace format

Metzger, Markus T
2015-02-04T08:25:25Z

> -----Original Message-----
> From: Metzger, Markus T
> Sent: Thursday, January 29, 2015 5:28 PM
> To: palves@redhat.com

Hello Pedro,

> btrace: add struct btrace_data
> btrace: add format argument to supports_btrace
> btrace, linux: add perf event buffer abstraction
> record btrace: add configuration struct
> record-btrace: add bts buffer size configuration option
> btrace: update btrace_compute_ftrace parameters
> btrace: extend struct btrace_insn
> btrace: identify cpu
> record-btrace: indicate gaps

I don't think it was a very good idea from me to extend the patch series
while under review. Let's focus on the above patches from the original
series...

> btrace: less debug output
> btrace: work around _dl_runtime_resolve returning to resolved function
> btrace: support 32-bit inferior on 64-bit host
> btrace: increase buffer size for exception test

... and ignore the new bug-fix patches. I'll send them in a new, separate
review request. I found another bug I see on some targets and I'm working
on simplifying the test suite. If I keep adding (those) patches to this series,
we will never get anywhere with it.

Makes sense?

Markus.

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052