Re: [Patch] Fix build problem with system call in compile/compile.c

Yao Qi
2015-01-06T03:09:00Z

"Steve Ellcey " <sellcey@imgtec.com> writes:

Hi, Steve,
Thanks for fixing this build failure...

> /scratch/sellcey/repos/nightly_test/src/binutils-gdb/gdb/compile/compile.c:175:10: error: ignoring return value of 'system', declared with attribute warn_unused_result [-Werror=unused-result]
> cc1: all warnings being treated as errors
> make[1]: *** [compile.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory `/scratch/sellcey/repos/nightly_test/obj-mips-img-linux-gnu/binutils-gdb/gdb'
> make: *** [all-gdb] Error 2
>
> I am not sure why other people aren't running into this but I would like to
> apply this patch to fix the build problem.

Other people run into this too, Renlin Li opened PR 17718 for the build failure,
https://sourceware.org/bugzilla/show_bug.cgi?id=17718 and Chen Gang
proposed a similar fix to the same problem
https://sourceware.org/ml/gdb-patches/2015-01/msg00011.html

This build failure wasn't fixed because people discuss that we can replace
system ("rm -rf") with ftw/rmdir/unlink, https://sourceware.org/ml/gdb-patches/2014-12/msg00501.html
but the discussion looks stalled due to the holiday. It's unclear to me
when the discussion can be closed and we have an acceptable fix. We
should fix it by next week (7.9 branching).

>
> OK to checkin?

I don't have an objection to this patch, but please wait for a while to
see what do other people think of this patch.

--
Yao (齐尧)