Re: [Patch] Fix build problem with system call in compile/compile.c

Joel Brobecker
2015-01-10T04:30:16Z

> Excuse me, I am not quite familiar with the patch apply working flow for
> binutils/gdb, it seems each patch can only have one 'Signed-of-by' for
> it (do not like Linux kernel or QEMU, can have multiple 'Signed-of-by').
>
> For me, this patch need multiple 'Signed-of-by': I start the patch, and
> Pedro Alves give a very necessary improvement (or it will introduce a
> new bug, which is not recognized quite obviously by others).

I know you've answered your own question about your patch in particular,
but I wanted to clarify a couple of things.

About "can only have one 'Signed-off-by'":

We do not use git's sign-off (at least, not at the moment).
As you know, there is an approval process through this mailing
list which is used instead, but who actually approves the patch
is not recorded in the git commit.

However, the approver is not the same thing at the author, or
the group of authors. If you are the sole author of a patch,
and I request a few small changes that you make, and then it
gets approved, you are still the sole author of those changes.
Hence your name remains the only name listed in the corresponding
ChangeLog entries. There is a small exception where a reviewer
contributes significant ideas towards the final patch, or even
contributes pieces of it, in which case the reviewer now also
becomes co-author, in which case his name gets added to the
corresponding ChangeLog entries.

> If what I said above is correct, one way maybe, apply my original patch
> firstly, then apply the fix patch by Pedro Alves. I am not quite sure
> whether this way is suitable or not, though.

About that:

We avoid that approach, because it introduces a commit where
we know there is an issue. Although the issue is supposed to
get fixed right after, it still isn't great in the context of
"git bisect" for instance.

--
Joel