Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Taylor <dtaylor@emc.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Document short responses to qXfer:object:read.
Date: Fri, 27 May 2016 16:52:00 -0000	[thread overview]
Message-ID: <14203.1464367919@usendtaylorx2l> (raw)

> From: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 27 May 2016 11:35:27 +0300


> It very much does, thanks.  I have 3 follow-up questions:
> 
>  . It's not clear to me what is the "returned amount" here, as the
>    listed responses for this packet don't seem to provide the amount
>    of data in the response.  Do you mean the length of the data in the
>    "m DATA" or "l DATA" responses, counted in bytes?
> 
>  . What is a zero-length response?  Is that "l" without data?
> 
>  . If my interpretation of the above 2 issues is correct, then why do we
>    need this new text you suggest?  The 'm' and 'l' responses already
>    say that the data can be shorter than the request, which seems to
>    be what the new text says.
> 
> Finally, it looks to me that we should move the description of the
> responses to precede the details of the 'read' requests, since the
> list of those requests is very long, and thus the promised description
> of the responses "below" is very far away, which IMO gets in the way
> of reading and comprehending the issue.
> 
> > Now, can we come up with better wording?
> 
> After we've figured out the above left-overs, sure.
> 
> Thanks.

I didn't pay attention to that as it was far enough after the text in
question and looked -- at quick glance -- like it was part of the osdata
description and therefore not relevant to threads.

Taking a longer look, it clearly is relevant.

It addresses most of my concerns and moving it, as you suggested, would
definitely, IMO, help.

Thanks.


             reply	other threads:[~2016-05-27 16:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 16:52 David Taylor [this message]
2016-05-27 18:47 ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2016-05-26 20:33 David Taylor
2016-05-27  8:35 ` Eli Zaretskii
2016-05-27  8:55   ` Pedro Alves
2016-05-27 13:21     ` Eli Zaretskii
2016-05-27 13:48       ` Pedro Alves
2016-05-27 14:03         ` Eli Zaretskii
2016-05-26 18:11 David Taylor
2016-05-26 19:32 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14203.1464367919@usendtaylorx2l \
    --to=dtaylor@emc.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox