From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21644 invoked by alias); 17 Dec 2014 17:30:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21626 invoked by uid 89); 17 Dec 2014 17:30:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Dec 2014 17:30:05 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 111F8C1AF664C; Wed, 17 Dec 2014 17:29:59 +0000 (GMT) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 17 Dec 2014 17:30:02 +0000 Received: from [192.168.65.53] (192.168.65.53) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 17 Dec 2014 09:29:51 -0800 Message-ID: <1418837391.3123.45.camel@ubuntu-sellcey> Subject: Re: [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] From: Steve Ellcey Reply-To: To: Eli Zaretskii CC: Jan Kratochvil , , , , Date: Wed, 17 Dec 2014 17:30:00 -0000 In-Reply-To: <83tx0ww9dl.fsf@gnu.org> References: <83tx0ww9dl.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2014-12/txt/msg00486.txt.bz2 On Tue, 2014-12-16 at 05:39 +0200, Eli Zaretskii wrote: > > Date: Mon, 15 Dec 2014 23:55:51 +0100 > > From: Jan Kratochvil > > Cc: brobecker@adacore.com, yao@codesourcery.com, gdb-patches@sourceware.org, > > ktietz@redhat.com > > > > On Mon, 15 Dec 2014 23:28:01 +0100, Jan Kratochvil wrote: > > > The 'compile' project needs a larger port effort to run on MS-Windows. > > > > For example there is also > > > > compile/compile.c: > > zap = concat ("rm -rf ", dir, (char *) NULL); > > system (zap); > > Yuck! Do we really allow such atrocities in GDB? What if 'rm' is > some unrelated or even malicious script? > > I think this should be replaced by suitable C function calls. IMO, > this kind of programming is OK for prototyping, but not for the final > code. I am running into a different problem with the system call. I am building on Linux using the latest GCC and glibc (unreleased top of tree sources) and my build fails with: /scratch/sellcey/repos/nightly2/src/binutils-gdb/gdb/compile/compile.c:175:10: error: ignoring return value of 'system', declared with attribute warn_unused_result [-Werror=unused-result] cc1: all warnings being treated as errors make[1]: *** [compile.o] Error 1 If we don't get rid of the system call can we at least check the return value of system? Steve Ellcey sellcey@imgtec.com