Re: [PATCH v2 03/13] btrace, linux: add perf event buffer abstraction

Pedro Alves
2015-01-27T15:52:49Z

On 01/27/2015 03:31 PM, Metzger, Markus T wrote:

>> Isn't there a better type to use here instead of "long long"?
>> Why not size_t, if a host buffer size; uint64_t, if it's a fixed
>> buffer format, assuming 64-bit here; or ULONGEST, the widest
>> integer we support?
>
> I'm using the same data type as the respective fields in
> struct perf_event_mmap_page (after resolving a few typedefs).
>
> I'm also fine to directly use __u64 or to use uint64_t.

Ah, so fits in "fixed format" category. Let's go with
uint64_t then.

Thanks,
Pedro Alves