Re: [PATCH 01/16 v2] Refactor native follow-fork

Breazeal, Don
2014-09-30T18:43:26Z

On 9/30/2014 3:56 AM, Pedro Alves wrote:
> On 09/29/2014 07:07 PM, Breazeal, Don wrote:
>
>> The patch is standalone and I believe it has value independent
>> of the rest of the series.
>
> Yes, agreed.
>
>> OK to push?
>
> Yes, please push.
>
>> +/* Handle changes to the inferior list based on the type of fork,
>> + which process is being followed, and whether the other process
>> + should be detached. On entry inferior_ptid must be the ptid of
>> + the fork parent. At return inferior_ptid is the ptid of the
>> + followed inferior. */
>> +
>> +int
>
> 'static int' here too.
>
> Consider putting the function above its caller thus avoiding
> the need for the other declaration at the top.
>
>> +follow_fork_inferior (int follow_child, int detach_fork)
>> +{
>
> Thanks,
> Pedro Alves
>
Patch is pushed with changes.
Thanks,
--Don