From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 5/6] Fix implptr-optimized-out.exp fail
Date: Sat, 25 Oct 2014 00:18:00 -0000 [thread overview]
Message-ID: <1414195968-3333-6-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1414195968-3333-1-git-send-email-yao@codesourcery.com>
Hi,
I see the fail in gdb.dwarf2/implptr-optimized-out.exp in thumb mode
(gdb) p p->f^M
No symbol "p" in current context.^M
(gdb) FAIL: gdb.dwarf2/implptr-optimized-out.exp: p p->f
and the crash on powerpc64
(gdb) continue^M
Continuing.^M
^M
Program received signal SIGSEGV, Segmentation fault.^M
0x7d82100810000828 in ?? ()
The cause of both is that we incorrectly set attribute low_pc, since
main isn't resolved to function start address on these targets.
In this patch, we replace attributes name, low_pc and high_pc with
MACRO_AT_func. The fail on thumb mode is fixed, and crash on
powerpc64 is fixed too.
gdb/testsuite:
2014-10-24 Yao Qi <yao@codesourcery.com>
* gdb.dwarf2/implptr-optimized-out.exp (Dwarf::assemble):
Replace name, low_pc and high_pc with MACRO_AT_func.
---
gdb/testsuite/gdb.dwarf2/implptr-optimized-out.exp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.dwarf2/implptr-optimized-out.exp b/gdb/testsuite/gdb.dwarf2/implptr-optimized-out.exp
index 226fc5c..dd9c517 100644
--- a/gdb/testsuite/gdb.dwarf2/implptr-optimized-out.exp
+++ b/gdb/testsuite/gdb.dwarf2/implptr-optimized-out.exp
@@ -25,6 +25,8 @@ set executable ${testfile}
# Create the DWARF.
set asm_file [standard_output_file $srcfile2]
Dwarf::assemble $asm_file {
+ global srcdir subdir srcfile
+
cu { version 3 addr_size 4 } {
compile_unit {
{producer "GNU C 4.4.3"}
@@ -51,9 +53,7 @@ Dwarf::assemble $asm_file {
}
subprogram {
- {name main}
- {low_pc main addr}
- {high_pc main+0x100 addr}
+ {MACRO_AT_func { main ${srcdir}/${subdir}/${srcfile} }}
{type :$int_label}
{external 1 flag}
} {
--
1.9.3
next prev parent reply other threads:[~2014-10-25 0:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 0:17 [PATCH 0/6] Use correct function address in dwarf assembler Yao Qi
2014-10-25 0:18 ` [PATCH 3/6] Get start and end address of main in dwz.exp Yao Qi
2014-11-04 22:51 ` Doug Evans
2014-10-25 0:18 ` [PATCH 1/6] New proc _handle_attribute Yao Qi
2014-11-04 22:48 ` Doug Evans
2014-10-25 0:18 ` Yao Qi [this message]
2014-11-04 22:53 ` [PATCH 5/6] Fix implptr-optimized-out.exp fail Doug Evans
2014-10-25 0:18 ` [PATCH 6/6] Fix dw2-ifort-parameter.exp fail with clang Yao Qi
2014-11-04 22:54 ` Doug Evans
2014-10-25 0:18 ` [PATCH 4/6] Use Dwarf::assemble in implptr-optimized-out.exp Yao Qi
2014-11-04 22:53 ` Doug Evans
2014-10-25 0:18 ` [PATCH 2/6] DW attribute macro MACRO_AT_func and MACRO_AT_range Yao Qi
2014-11-04 22:50 ` Doug Evans
2014-11-05 1:54 ` Yao Qi
2014-11-07 16:54 ` Doug Evans
2014-11-10 2:04 ` Yao Qi
2014-11-10 19:44 ` Doug Evans
2014-11-11 2:05 ` Yao Qi
2014-11-12 7:01 ` Doug Evans
2014-11-14 1:00 ` Yao Qi
2014-11-04 22:59 ` Doug Evans
2014-11-04 23:01 ` [PATCH 0/6] Use correct function address in dwarf assembler Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414195968-3333-6-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox