Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Victor Kamensky <victor.kamensky@linaro.org>
To: gdb-patches@sourceware.org
Cc: victor.kamensky@linaro.org
Subject: [PATCH 2/5] ARM: extract_arm_insn function need to read instrs correctly in be8 case
Date: Tue, 21 Oct 2014 00:57:00 -0000	[thread overview]
Message-ID: <1413853021-4393-3-git-send-email-victor.kamensky@linaro.org> (raw)
In-Reply-To: <1413853021-4393-1-git-send-email-victor.kamensky@linaro.org>

extract_arm_insn function needs to read instructions in
gdbarch_byte_order_for_code byte order, because in case armv7b,
even data is big endian, instructions are still little endian.
Currently function uses gdbarch_byte_order which would be
big endian in armv7b case.

Because of this issue pretty much all gdb.reverse/ tests are
failing with 'Process record does not support instruction' message.

Fix is to change gdbarch_byte_order to gdbarch_byte_order_for_code,
when passed to extract_unsigned_integer that reads instruction.
---
 gdb/ChangeLog  | 5 +++++
 gdb/arm-tdep.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c967a93..2aef5dc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-10-13  Victor Kamensky  <victor.kamensky@linaro.org>
+
+	* arm-tdep.c (extract_arm_insn): use dbarch_byte_order_for_code
+	to read arm instruction.
+
 2014-09-30  Don Breazeal  <donb@codesourcery.com>
 
 	* inf-ptrace.c (inf_ptrace_follow_fork): Remove target-independent
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index e2559ec..e7a1ec5 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -13860,7 +13860,7 @@ extract_arm_insn (insn_decode_record *insn_record, uint32_t insn_size)
     return 1;
   insn_record->arm_insn = (uint32_t) extract_unsigned_integer (&buf[0],
                            insn_size, 
-                           gdbarch_byte_order (insn_record->gdbarch));
+			   gdbarch_byte_order_for_code (insn_record->gdbarch));
   return 0;
 }
 
-- 
1.8.1.4


  parent reply	other threads:[~2014-10-21  0:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21  0:57 [PATCH 0/5] arm: set of big endian related fixes for armeb (v7) Victor Kamensky
2014-10-21  0:57 ` [PATCH 1/5] ARM: plt_size functions need to read instructions in right byte order Victor Kamensky
2014-10-21  0:57 ` [PATCH 3/5] ARM: arm_breakpoint should be little endian form in case for arm BE8 Victor Kamensky
2014-10-21  8:13   ` Yao Qi
2014-10-21  0:57 ` Victor Kamensky [this message]
2014-10-21  7:58   ` [PATCH 2/5] ARM: extract_arm_insn function need to read instrs correctly in be8 case Yao Qi
2014-10-21  8:04     ` Yao Qi
2014-10-21 14:45     ` Victor Kamensky
2014-10-24 12:20       ` gdb/CONTRIBUTE Pedro Alves
2014-10-24 17:36         ` gdb/CONTRIBUTE Victor Kamensky
2014-10-21  0:57 ` [PATCH 5/5] ARM: asm-source.exp link options in case of armv7b target Victor Kamensky
2014-10-24  6:10   ` Yao Qi
2014-10-24  6:35     ` Victor Kamensky
2014-10-24  6:38       ` Andrew Pinski
2014-10-24  8:57         ` Yao Qi
2014-10-24 17:11           ` Victor Kamensky
2014-10-21  0:57 ` [PATCH 4/5] ARM: read_pieced_value do big endian processing only in case of valid gdb_regnum Victor Kamensky
2014-10-22  9:31   ` Yao Qi
2014-10-22 15:27     ` Victor Kamensky
2014-10-23  3:22       ` Yao Qi
2014-10-23  5:43         ` Victor Kamensky
2014-10-23  6:24           ` Yao Qi
2014-10-21  1:12 ` [PATCH 0/5] arm: set of big endian related fixes for armeb (v7) Andrew Pinski
2014-10-21  5:22   ` Victor Kamensky
2014-10-21  7:39 ` Yao Qi
2014-10-22  5:39   ` Victor Kamensky
2014-10-22  9:36     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413853021-4393-3-git-send-email-victor.kamensky@linaro.org \
    --to=victor.kamensky@linaro.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox