From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20692 invoked by alias); 9 Oct 2014 18:00:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20638 invoked by uid 89); 9 Oct 2014 18:00:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Oct 2014 18:00:32 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s99I0Vo1021395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 9 Oct 2014 14:00:31 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s99I0TSb020799 for ; Thu, 9 Oct 2014 14:00:30 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 0/4] Fix a set of terminal/readline handling bugs/crashes Date: Thu, 09 Oct 2014 18:00:00 -0000 Message-Id: <1412877629-12052-1-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2014-10/txt/msg00214.txt.bz2 This series fixes a couple terminal/readline handling bugs that result in GDB crashing with: readline: readline_callback_read_char() called with no handler! Aborted (core dumped) $ ... and also a bug where we lose the "&" when repeating background commands. Because the these won't trigger without target-async, the first two are user-visible regressions in 7.8, which has async by default (7.7 didn't). As such, I'd like to include these in 7.8.1. For last one (gdb/17471), I'm a bit borderline (re. 7.8.1). Technically, it isn't really a regression, but still annoying (see gdb/17300). If you'd prefer not having that in 7.8.1, please do speak up. Tested on x86_64 Fedora 20, native and gdbserver. Pedro Alves (4): Make common code handle target_terminal_* idempotency PR gdb/17472: With annotations, input while executing in the foreground crashes readline/GDB PR gdb/17300: Input after "c -a" crashes readline/GDB PR gdb/17471: Repeating a background command makes it foreground gdb/annotate.c | 22 ++- gdb/infcmd.c | 160 ++++++++++++++------- gdb/target.c | 64 +++++++++ gdb/target.h | 25 ++-- .../gdb.base/annota-input-while-running.c | 25 ++++ .../gdb.base/annota-input-while-running.exp | 130 +++++++++++++++++ gdb/testsuite/gdb.base/bg-execution-repeat.c | 33 +++++ gdb/testsuite/gdb.base/bg-execution-repeat.exp | 86 +++++++++++ .../gdb.base/continue-all-already-running.c | 25 ++++ .../gdb.base/continue-all-already-running.exp | 79 ++++++++++ gdb/windows-nat.c | 2 +- 11 files changed, 582 insertions(+), 69 deletions(-) create mode 100644 gdb/testsuite/gdb.base/annota-input-while-running.c create mode 100644 gdb/testsuite/gdb.base/annota-input-while-running.exp create mode 100644 gdb/testsuite/gdb.base/bg-execution-repeat.c create mode 100644 gdb/testsuite/gdb.base/bg-execution-repeat.exp create mode 100644 gdb/testsuite/gdb.base/continue-all-already-running.c create mode 100644 gdb/testsuite/gdb.base/continue-all-already-running.exp -- 1.9.3