Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] remote thread listing: get rid of unnecessary "thread alive?" traffic
Date: Thu, 02 Oct 2014 16:21:00 -0000	[thread overview]
Message-ID: <1412266896-28210-1-git-send-email-palves@redhat.com> (raw)

When GDB wants to sync the thread list with the target's (e.g., due to
"info threads"), it ends up sending a bunch of T (thread alive?)
packets before fetching the current remote thread list:

 Sending packet: $Tp2141.2150#82...Packet received: OK
 Sending packet: $Tp2141.214f#b7...Packet received: OK
 Sending packet: $Tp2141.2141#82...Packet received: OK
 Sending packet: $qXfer:threads:read::0,fff#03...Packet received: l<threads>\n<thread id="p2141.2141" core="2"/>\n<thread id="p2141.214f" core="1"/>\n<thread id="p2141.2150" core="2"/>\n</threads>\n

That's wasteful, given that we can tell whether a thread is gone from
the fact that it won't appear in the list returned by
qXfer:threads:read (or qfThreadInfo/qsThreadInfo, or qL).

This series eliminates those unnecessary queries.

IOW, after this series, the above becomes simply:

 Sending packet: $qXfer:threads:read::0,fff#03...Packet received: l<threads>\n<thread id="p2141.2141" core="2"/>\n<thread id="p2141.214f" core="1"/>\n<thread id="p2141.2150" core="2"/>\n</threads>\n

Pedro Alves (4):
  Merge remote thread listing methods
  Push pruning old threads down to the target
  remote: get rid of all the T packets when synching the thread list
  DEC threads: Simplify updating the thread list

 gdb/ada-tasks.c        |   4 +-
 gdb/bsd-uthread.c      |   6 +-
 gdb/corelow.c          |   2 +-
 gdb/dec-thread.c       |  80 ++++--------
 gdb/gdbthread.h        |  12 ++
 gdb/linux-thread-db.c  |   6 +-
 gdb/nto-procfs.c       |  10 +-
 gdb/obsd-nat.c         |   6 +-
 gdb/procfs.c           |  10 +-
 gdb/ravenscar-thread.c |  10 +-
 gdb/record-btrace.c    |  10 +-
 gdb/remote.c           | 339 +++++++++++++++++++++++++++++--------------------
 gdb/sol-thread.c       |  21 +--
 gdb/target-delegates.c |  22 ++--
 gdb/target.c           |   4 +-
 gdb/target.h           |   6 +-
 gdb/thread.c           |   8 +-
 17 files changed, 301 insertions(+), 255 deletions(-)

-- 
1.9.3


             reply	other threads:[~2014-10-02 16:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 16:21 Pedro Alves [this message]
2014-10-02 16:21 ` [PATCH 4/4] DEC threads: Simplify updating the thread list Pedro Alves
2014-10-02 18:46   ` Mark Kettenis
2014-10-03  9:12     ` Pedro Alves
2014-10-02 16:21 ` [PATCH 2/4] Push pruning old threads down to the target Pedro Alves
2016-12-09  6:38   ` Thomas Schwinge
2014-10-02 16:21 ` [PATCH 1/4] Merge remote thread listing methods Pedro Alves
2014-10-17  8:57   ` Jiong Wang
2014-10-17 10:17     ` [PATCH] Fix build without libexpat (Re: [PATCH 1/4] Merge remote thread listing methods) Pedro Alves
2014-10-17 10:21       ` Jiong Wang
2014-10-02 16:21 ` [PATCH 3/4] remote: get rid of all the T packets when synching the thread list Pedro Alves
2014-10-15 22:01 ` [pushed] Re: [PATCH 0/4] remote thread listing: get rid of unnecessary "thread alive?" traffic Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412266896-28210-1-git-send-email-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox