From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11543 invoked by alias); 26 Sep 2014 00:39:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11390 invoked by uid 89); 26 Sep 2014 00:39:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 26 Sep 2014 00:39:52 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8Q0dp4T025122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 25 Sep 2014 20:39:51 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8Q0dgFD019425 for ; Thu, 25 Sep 2014 20:39:50 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 5/9] Switch back to stepped thread: clear step-over info Date: Fri, 26 Sep 2014 00:40:00 -0000 Message-Id: <1411691982-10744-6-git-send-email-palves@redhat.com> In-Reply-To: <1411691982-10744-1-git-send-email-palves@redhat.com> References: <1411691982-10744-1-git-send-email-palves@redhat.com> X-SW-Source: 2014-09/txt/msg00762.txt.bz2 This path misses clearing the step-over info, because it bypasses keep_going. The testsuite caught this while I was working on making software single-step breakpoints per-thread. Unfortunately, I didn't keep the logs around and I don't recall ATM which test tripped on this. gdb/ 2014-09-25 Pedro Alves * infrun.c (switch_back_to_stepped_thread) : Clear step-over info. --- gdb/infrun.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/infrun.c b/gdb/infrun.c index 94a58b2..e0df9bf 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -5275,6 +5275,13 @@ switch_back_to_stepped_thread (struct execution_control_state *ecs) fprintf_unfiltered (gdb_stdlog, "infrun: expected thread advanced also\n"); + /* Clear this before trying to insert the sss + breakpoint, in case we were previously trying to step + over this location in another thread, otherwise the + breakpoint ends up _not_ installed. It's what + keep_going would do too, if we called it. */ + clear_step_over_info (); + insert_single_step_breakpoint (get_frame_arch (frame), get_frame_address_space (frame), stop_pc); -- 1.9.3