Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>, Doug Evans <dje@google.com>
Subject: [PATCH 2/3] Update target_stop's documentation
Date: Thu, 18 Sep 2014 09:59:00 -0000	[thread overview]
Message-ID: <1411034346-868-3-git-send-email-gbenson@redhat.com> (raw)
In-Reply-To: <1411034346-868-1-git-send-email-gbenson@redhat.com>

This commit updates target_stop's documentation to clarify that
it is asynchronous.

gdb/ChangeLog:

	* target.c (target_stop): Updated comment.
---
 gdb/ChangeLog |    4 ++++
 gdb/target.h  |    6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/target.h b/gdb/target.h
index 2ea7a2d..24fb757 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1573,8 +1573,10 @@ extern int target_thread_alive (ptid_t ptid);
 extern void target_find_new_threads (void);
 
 /* Make target stop in a continuable fashion.  (For instance, under
-   Unix, this should act like SIGSTOP).  This function is normally
-   used by GUIs to implement a stop button.  */
+   Unix, this should act like SIGSTOP).  Note that this function is
+   asynchronous: it does not wait for the target to become stopped
+   before returning.  If this is the behaviour you want please use
+   target_stop_and_wait.  */
 
 extern void target_stop (ptid_t ptid);
 
-- 
1.7.1


  parent reply	other threads:[~2014-09-18  9:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18  9:59 [PATCH 0/3] target_{stop,continue} things Gary Benson
2014-09-18  9:59 ` [PATCH 3/3] Wait for target to stop before running agent commands Gary Benson
2014-09-19 16:16   ` Pedro Alves
2014-09-18  9:59 ` Gary Benson [this message]
2014-09-19 16:38   ` [PATCH 2/3] Update target_stop's documentation Pedro Alves
2014-09-22 10:35     ` Gary Benson
2014-09-18  9:59 ` [PATCH 1/3] Rename target_{stop,continue}_ptid Gary Benson
2014-09-19 16:16   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411034346-868-3-git-send-email-gbenson@redhat.com \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox