From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73223 invoked by alias); 3 Mar 2020 21:12:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73215 invoked by uid 89); 3 Mar 2020 21:12:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=fond, H*x:5.0, H*x:Windows X-HELO: sonic301-22.consmr.mail.ir2.yahoo.com Received: from sonic301-22.consmr.mail.ir2.yahoo.com (HELO sonic301-22.consmr.mail.ir2.yahoo.com) (77.238.176.99) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 21:12:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1583269958; bh=UORIQgMeoRv68tX853rnFS79NQcj+XG8wgumLOnk8kc=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=cJFnouzUFj9AElvba6qslr/E0NXsiPI/twO8EsxMGXNsGlc1D/9M6Tg6W2vckpRP077MSWfWpdT5CWqEsG2K0hlDDuk18oOqS+VRArjR8cJVFLTEr21YyRj1tmJtrpEwugj7TwMN6Bjzi+sb/tNlo5hb33V4MR3r1cT4ZCgJAbX3/rEsCViIVabwMo7IGkiPjgstyrIWplg2x849wOAKFTIhoPi2C77dMHrDEMdIhexEMNkZsz6oxD37q7cRniPIaDO774m51rcic8aQahy5LUbgbhubnfQMBCB/xQzDhIWAi4UeD3So2LfzGQ7qOydQeTou3DHqLz0Q5KMYqHdV/Q== Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Tue, 3 Mar 2020 21:12:38 +0000 Date: Tue, 03 Mar 2020 21:12:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <140963475.6133151.1583269956021@mail.yahoo.com> In-Reply-To: References: <20200303182057.8973-1-ssbssa.ref@yahoo.de> <20200303182057.8973-1-ssbssa@yahoo.de> <834kv5xoef.fsf@gnu.org> <1055408447.6034972.1583262721877@mail.yahoo.com> <83y2shw81q.fsf@gnu.org> <4b854f69-10ea-eada-f4ba-245a02aae2e6@simark.ca> <83wo81w5cu.fsf@gnu.org> Subject: Re: [PATCH] Implement debugging of WOW64 processes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00072.txt Am Dienstag, 3. M=C3=A4rz 2020, 22:01:00 MEZ hat Simon Marchi Folgendes geschrieben: > On 2020-03-03 3:28 p.m., Eli Zaretskii wrote: > >> Cc: gdb-patches@sourceware.org > >> From: Simon Marchi > >> Date: Tue, 3 Mar 2020 14:36:53 -0500 > >> > >> Eli, just wondering, did you review the code parts of this patch? > > > > I've read it, yes.=C2=A0 I cannot say I know this area of Windows APIs = well > > enough to say something intelligent, though.=C2=A0 If the patch was tes= ted > > with 32-bit programs, I think it's OK. > > OK, thanks.=C2=A0 I've been looking at these Windows patches because nobo= dy else > was reviewing them.=C2=A0 I don't mind keeping doing that, but keep in mi= nd that > I don't know Windows nearly as much as you, so I really appreciate that y= ou > take a look. > > I looked at this patch quickly, it seems to add some code duplication and > complexity, but that looks difficult to avoid without some serious refact= oring > (which would of course be nice, but not required for adding this feature). I'm not very fond of the code duplication either. The only way I can think of, is to refactor it into template functions that can accept both CONTEXT or WOW64_CONTEXT. Is this what you had in mind also, or do you have a better idea? > The only bit I don't particularly like is the inclusion of i386-windows-n= at.c > in amd64-windows-nat.c, that just seems weird, and not very good in a lon= g term > maintenance perspective. > > Can you instead include the i386-windows-nat.c file in the cygwin64 and m= ingw64 > builds (in configure.nat), so that it gets compiled in a more standard fa= shion? Yes, I can do that. I didn't even know that configure.nat was the place for this, that's why I did it with the include. Regards Hannes Domani