From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13487 invoked by alias); 22 Aug 2014 19:05:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13476 invoked by uid 89); 22 Aug 2014 19:05:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 22 Aug 2014 19:05:22 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 03.01.05330.AEF37F35; Fri, 22 Aug 2014 15:04:42 +0200 (CEST) Received: from simark-hp.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.90) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 22 Aug 2014 15:05:18 -0400 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH v3 1/2] Only leave dprintf inserted if it is marked as persistent (PR breakpoints/17012) Date: Fri, 22 Aug 2014 19:05:00 -0000 Message-ID: <1408734315-21207-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00506.txt.bz2 On Linux native, if dprintf are inserted when detaching, they are left in the inferior which causes it to crash from a SIGTRAP. It also happens with dprintfs on remote targets, when set disconnected-dprintf is off. I believe that the rationale of the line I modified was to leave dprinfs inserted in order to support disconnected dprintfs. This adds a check to see if the dprintf should actually stay inserted or not. bl->target_info.persist will be 1 only if disconnected-dprintf is on and we are debugging a remote target. On native, it will always be 0, regardless of the value of disconnected-dprintf. This makes sense, since disconnected dprintfs are not supported by the native target. New in v3: * Follow-up Pedro's review * Remove == 1 for check on boolean. gdb/Changelog: PR breakpoints/17012 * breakpoint.c (remove_breakpoints_pid): Only skip removing dprintf if it is marked as persistent. --- gdb/breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 683ed2b..01e9b36 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -3110,7 +3110,7 @@ remove_breakpoints_pid (int pid) if (bl->pspace != inf->pspace) continue; - if (bl->owner->type == bp_dprintf) + if (bl->owner->type == bp_dprintf && bl->target_info.persist) continue; if (bl->inserted) -- 2.1.0