Re: [PATCH 1/3] Check function is GC'ed

Yao Qi
2014-09-19T09:08:30Z

Doug Evans <dje@google.com> writes:

> > gdb:
> >
> > 2014-09-16 Yao Qi <yao@codesourcery.com>
> >
> > * dwarf2read.c (dwarf_decode_lines): Update declaration.
> > (handle_DW_AT_stmt_list): Add argument 'lowpc'. Update
> > comments. Callers update.
> > (dwarf_decode_lines): Likewise.
> > (dwarf_decode_lines_1): Add argument 'lowpc'. Update
> > comments. Skip the line table if 'lowpc' is greater than
> > 'address'. Don't check
> > dwarf2_per_objfile->has_section_at_zero.
> >
> > gdb/testsuite:
> >
> > 2014-09-16 Yao Qi <yao@codesourcery.com>
> >
> > * gdb.base/break-on-linker-gcd-function.exp: Move test into new
> > proc set_breakpoint_on_gcd_function. Invoke
> > set_breakpoint_on_gcd_function. Restart GDB with --readnow and
> > invoke set_breakpoint_on_gcd_function again.
>
> LGTM.

Thanks for the review. Patch is pushed in.

--
Yao (齐尧)