Re: [PATCH 06/16 v3] Extended-remote Linux follow fork

Breazeal, Don
2014-11-13T19:06:25Z

On 11/13/2014 10:59 AM, Pedro Alves wrote:
> On 11/13/2014 06:53 PM, Breazeal, Don wrote:
>> My initial approach was to do just that, but I ended up with
>> linux-specific code in remote.c (the code that lives in linux-nat.c
>> for the native implementation). I guess the direction of recent
>> changes would be to put that code into a common file in gdb/nat,
>> if possible. Would that be the approach you would recommend?
>
> I'm not seeing what would be linux-specific? On remote_follow_fork
> fork, we switch the current remote thread to gdb's current
> thread (either parent or child), by
> calling 'set_general_thread (inferior_ptid);'
> And then if we need to detach parent or child, we detach it with
> the D;PID packet.
>
> Thanks,
> Pedro Alves
>
I don't recall the details at this point. I'll proceed
with your recommendation, assuming I don't need any
common code, and if I run into a problem I'll post a
question about it.

Thanks
--Don