From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/8] Error handling cleanups
Date: Wed, 06 Aug 2014 10:12:00 -0000 [thread overview]
Message-ID: <1407319948-2264-1-git-send-email-gbenson@redhat.com> (raw)
Hi all,
GDB's various error handling functions do not work until a certain
amount of setup has been performed. For regular warnings and errors
this is an annoyance: error handling needs to be hardwired with
fprintf and/or exit until error and warning may be called. For
internal warnings and errors this is a real problem: internal errors
can occur from almost the first line of captured_main, but they don't
actually work until much later.
This series modifies internal_vproblem to always work, and modifies
warning and error to work much earlier. It then replaces all the
hardwired early warning/error code with standard calls to warning and
error.
While looking at this I found several other hardwired error handlers
that do not seem to be necessary. I've replaced those in separate
patches.
While switching to warning/error I've fixed some inconsistencies that
have crept in over time: some messages wern't wrapped with _(), for
example, and some but not all warning messages were prefixed with
argv[0]. For the latter case I've made it so that all warnings
emitted prior to and during option processing--before print_gdb_version
basically--are prefixed by argv[0] and all other warnings are not.
Built and regtested on RHEL6.5 x86_64.
Ok to commit?
Thanks,
Gary
next reply other threads:[~2014-08-06 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 10:12 Gary Benson [this message]
2014-08-06 10:12 ` [PATCH 3/8] Make warning usable earlier Gary Benson
2014-08-06 10:12 ` [PATCH 8/8] Unify startup and option-parsing warnings Gary Benson
2014-08-06 10:12 ` [PATCH 4/8] Replace hardwired error handlers in tui_initialize_io Gary Benson
2014-08-06 10:12 ` [PATCH 2/8] Make error usable earlier Gary Benson
2014-08-06 10:25 ` [PATCH 7/8] Replace all usage errors with calls to error Gary Benson
2014-08-06 10:25 ` [PATCH 5/8] Replace hardwired error handler in captured_main Gary Benson
2014-08-06 10:34 ` [PATCH 1/8] Make internal_vproblem always work Gary Benson
2014-08-06 10:52 ` [PATCH 6/8] Replace hardwired error handler in go32_create_inferior Gary Benson
2014-08-06 16:59 ` Eli Zaretskii
2014-08-08 11:38 ` Gary Benson
2014-08-28 14:09 ` [PATCH 0/8] Error handling cleanups Pedro Alves
2014-08-29 9:19 ` [COMMITTED PATCH " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407319948-2264-1-git-send-email-gbenson@redhat.com \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox