Re: [PATCH 01/15 v3] Introduce common/errors.h

Gary Benson
2014-07-17T15:40:06Z

Pedro Alves wrote:
> On 07/17/2014 02:47 PM, Gary Benson wrote:
> > +/* Throw an error. The current operation will be aborted. The
> > + message will be issued to the user. The application will
> > + return to a state where it is accepting commands from the user. */
>
> These comments aren't really true, though. We have plenty of places
> catching errors with TRY_CATCH and proceeding without returning to a
> state where we're accepting commands from the user.

How about "Throw an error. The current operation will be aborted.
The application may catch and process the error, or, if not, the
message will be issued to the user and the application will return
to a state where it is accepting commands from the user."

> (We should really bite the bullet and move exceptions.{h|c} and
> cleanups.{h|c} to common/ and make gdbserver use them too.)

Can I leave this for another series please? This one's big enough
already.

Thanks,
Gary

--