Re: [PATCH 01/15 v3] Introduce common/errors.h

Pedro Alves
2014-07-17T15:07:31Z

On 07/17/2014 02:47 PM, Gary Benson wrote:
> +/* Throw an error. The current operation will be aborted. The
> + message will be issued to the user. The application will
> + return to a state where it is accepting commands from the user. */

These comments aren't really true, though. We have plenty of places
catching errors with TRY_CATCH and proceeding without returning to a
state where we're accepting commands from the user.

> +
> +extern void error (const char *fmt, ...)
> + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
> +

(We should really bite the bullet and move exceptions.{h|c} and
cleanups.{h|c} to common/ and make gdbserver use them too.)

--
Pedro Alves