Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [PATCH] Report "No hardware breakpoint support" correctly
Date: Tue, 15 Jul 2014 08:12:00 -0000	[thread overview]
Message-ID: <1405380516-13496-1-git-send-email-emachado@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140714161308.GC4888@adacore.com>

Thanks Uli and Joel for the feedback. I've just committed the patch below,
following Joel's suggestion:

	https://sourceware.org/ml/gdb-cvs/2014-07/msg00035.html

Thanks and regards,
--
Edjunior

gdb/
2014-07-14  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* ppc-linux-nat.c (ppc_linux_can_use_hw_breakpoint): Report no hardware
	breakpoint support correctly.

---
 gdb/ppc-linux-nat.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c
index fcfd452..6e8994e 100644
--- a/gdb/ppc-linux-nat.c
+++ b/gdb/ppc-linux-nat.c
@@ -1473,6 +1473,11 @@ ppc_linux_can_use_hw_breakpoint (struct target_ops *self,
     }
   else if (type == bp_hardware_breakpoint)
     {
+      if (total_hw_bp == 0)
+	{
+	  /* No hardware breakpoint support. */
+	  return 0;
+	}
       if (cnt > total_hw_bp)
 	return -1;
     }
-- 
1.8.4.2


      reply	other threads:[~2014-07-14 23:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 14:55 Edjunior Barbosa Machado
2014-07-14 15:54 ` Ulrich Weigand
2014-07-14 16:13 ` Joel Brobecker
2014-07-15  8:12   ` Edjunior Barbosa Machado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405380516-13496-1-git-send-email-emachado@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox