From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12992 invoked by alias); 9 Jul 2014 11:25:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12802 invoked by uid 89); 9 Jul 2014 11:25:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Jul 2014 11:25:51 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69AcB2V009396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 9 Jul 2014 06:38:12 -0400 Received: from blade.nx (ovpn-116-101.ams2.redhat.com [10.36.116.101]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s69AcApx020828 for ; Wed, 9 Jul 2014 06:38:11 -0400 Received: from blade.nx (localhost [127.0.0.1]) by blade.nx (Postfix) with ESMTP id 015C72640BF for ; Wed, 9 Jul 2014 11:38:09 +0100 (BST) From: Gary Benson To: gdb-patches@sourceware.org Subject: [PATCH 00/15] Common code cleanups Date: Wed, 09 Jul 2014 11:25:00 -0000 Message-Id: <1404902255-11101-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00172.txt.bz2 Hi all, The directories "common", "nat" and "target" contain code shared between GDB and gdbserver. Each C file is built at least twice, once for GDB and once for gdbserver, and many of the files use "#ifdef GDBSERVER" to source headers from GDB or gdbserver as appropriate. This means that while the code is shared, the supporting definitions are not, and in some cases these are different in non-trivial ways. In other places, GDBSERVER checks are used to cope where GDB and gdbserver do the same thing in different ways. This series reduces the number of GDBSERVER checks from 34 to 11. Tom Tromey started this work back in January, and I've updated it and extended it a little. Most of the remaining checks are to select the correct gnulib config header. Built and regtested on x86-64 RHEL6.5. gdbserver cross-built on linux-mips to check the mips-linux-watch.h changes. Ok to commit? Thanks, Gary -- http://gbenson.net/