From: Marc Khouzam <marc.khouzam@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Marc Khouzam <marc.khouzam@ericsson.com>
Subject: [PATCH] Assign 'targerr' instead of 'targ' to gdb_stdtargerr.
Date: Wed, 02 Jul 2014 19:14:00 -0000 [thread overview]
Message-ID: <1404328417-28116-1-git-send-email-marc.khouzam@ericsson.com> (raw)
Hi,
I noticed this what-seems-to-be-typo when browsing the code.
I'm not sure if the target can have two distinct streams or not
but the code seems to think so. I figure might as well fix it.
The original suspicious code was introduced at the same time as when
saved_output.targerr was added, so it really does look like a typo.
It was in commit 8d4d924b.
Is this ok?
Thanks
2014-07-02 Marc Khouzam <marc.khouzam@ericsson.com>
* cli/cli-logging.c (pop_output_files): Assign targerr to
gdb_stdtargerr.
diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
index ca2d76e..aae0039 100644
--- a/gdb/cli/cli-logging.c
+++ b/gdb/cli/cli-logging.c
@@ -171,7 +171,7 @@ pop_output_files (void)
gdb_stderr = saved_output.err;
gdb_stdlog = saved_output.log;
gdb_stdtarg = saved_output.targ;
- gdb_stdtargerr = saved_output.targ;
+ gdb_stdtargerr = saved_output.targerr;
}
saved_output.out = NULL;
--
1.7.9.5
next reply other threads:[~2014-07-02 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 19:14 Marc Khouzam [this message]
2014-07-03 18:16 ` Tom Tromey
2014-07-03 19:02 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404328417-28116-1-git-send-email-marc.khouzam@ericsson.com \
--to=marc.khouzam@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox