From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11110 invoked by alias); 27 Jun 2014 14:12:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11077 invoked by uid 89); 27 Jun 2014 14:12:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Jun 2014 14:12:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5RECi5c008841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Jun 2014 10:12:45 -0400 Received: from blade.nx (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5REChQi007047; Fri, 27 Jun 2014 10:12:43 -0400 Received: from blade.nx (localhost [127.0.0.1]) by blade.nx (Postfix) with ESMTP id 8B54B2624AB; Fri, 27 Jun 2014 15:12:42 +0100 (BST) From: Gary Benson To: gdb-patches@sourceware.org Cc: Mark Kettenis , Pedro Alves Subject: [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c Date: Fri, 27 Jun 2014 14:12:00 -0000 Message-Id: <1403878351-22974-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00937.txt.bz2 Hi all, This series is an updated version of the series I posted this morning. Mark Kettenis rightly pointed out that x86_linux_read_description was a mess of #ifdef spaghetti so I have rewritten it. Patch 2 has changed because that's where the x86_linux_read_description merge is. Patch 6 has changed because that's where the code is pulled from {i386,amd64}-linux-nat.c into x86-linux-nat.c. The remaining patches are the same. I've inlined the original description of the series below. Is this ok to commit? Thanks, Gary -- This series refactors the shared code in {i386,amd64}-linux-nat.c into the new files x86-linux-nat.[ch] and i386-linux-nat.h. The first five patches remove spurious changes between the files so that the code to be shared is identical: 1/7 - Rename identical functions 2/7 - Merge {i386,amd64}_linux_read_description 3/7 - Merge ps_get_thread_area 4/7 - Pull out common parts of _initialize_{i386,amd64}_linux_nat 5/7 - Comment and whitespace changes The sixth patch moves the shared code into the new files and does all the makefile and build system updates: 6/7 - Move duplicated code into new files The seventh patch tidies the blocks of #include directives at the tops of {i386,amd64}-linux-nat.c: 7/7 - Tidy #include lists This final patch is not strictly necessary for the series, but it makes things tidier.