From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8674 invoked by alias); 18 Jun 2014 15:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8644 invoked by uid 89); 18 Jun 2014 15:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 15:23:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5IFN3te005584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 18 Jun 2014 11:23:03 -0400 Received: from blade.nx (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5IFN2Ni000475 for ; Wed, 18 Jun 2014 11:23:03 -0400 Received: from blade.nx (localhost [127.0.0.1]) by blade.nx (Postfix) with ESMTP id C91812623F0 for ; Wed, 18 Jun 2014 16:23:01 +0100 (BST) From: Gary Benson To: gdb-patches@sourceware.org Subject: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch] Date: Wed, 18 Jun 2014 15:23:00 -0000 Message-Id: <1403104976-2492-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00671.txt.bz2 Hi all, This series continues on from the refactoring series I posted yesterday and partially committed today: 1 - Partially revert 4be83cc2b28ea09aa8ff789839e6520df60836f8 Pedro spotted that i386_{insert,remove}_hw_breakpoint could be further refactored. Patch 2 of this series does precisely that. This change means a number of functions I made nonstatic do not now have to be. This patch reverts that change. I apologise for this noise but the end result is better. 2 - Refactor i386_{insert,remove}_hw_breakpoint As above. 3 - Create nat/i386-dregs.c This patch moves all the code from the various files into the new file nat/i386-dregs.c and adds it to the buildsystem. 4 - Directly call i386-dregs functions This patch is a small tidyup of i386-nat.c. Is this ok to commit? Thanks, Gary -- http://gbenson.net/