Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it.

Pedro Alves
2014-06-12T18:17:56Z

Excellent, thanks.

On 06/12/2014 06:35 PM, Pierre Langlois wrote:

" I was wondering how to go about adding a test for this in
> the GDB testsuite. Could we include faulty dummy servers to test each packets?"

These two sentences shouldn't really be in the commit log.

But to answer, if we can make that work, I don't see why not.
I don't think that's a trivial effort though.

> + chain_before_invalidate_register =
> + make_cleanup_regcache_invalidate (regcache, regnum);

I missed this before, but '=' goes on the next line, like:

chain_before_invalidate_register
= make_cleanup_regcache_invalidate (regcache, regnum);

OK with these changes.

Thanks!

--
Pedro Alves