Re: [PATCH 5/7] Support for recording syscall on aarch64-linux

Omair Javaid
2014-06-11T07:11:17Z

On 6 June 2014 20:58, Andreas Arnez <arnez@linux.vnet.ibm.com> wrote:
> On Wed, Jun 04 2014, Omair Javaid wrote:
>
>> This patch adds support for recording system call instruction on aarch64-linux
>> targets.
>>
>> [...]
>> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> [...]
>> +
>> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
>> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
>> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
>> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
>
> Is this a typo? Otherwise the reason for this specialty should be
> documented in a comment here, IMO.
>
After a bit of digging up found out that AArch64 system calls take
between 0 and 7 arguments in register x1 to x7. I will update this
change with comment in upcoming update to this patch.