Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH] Add comment for mi_run_cmd_full
Date: Wed, 21 May 2014 21:48:00 -0000	[thread overview]
Message-ID: <1400708905-14184-1-git-send-email-simon.marchi@ericsson.com> (raw)

It should clear up confusion about the args parameter to mi_run_cmd_full.

If you have a better wording, let me know, I am not so good at that
english thing.

gdb/testsuite/ChangeLog:

2014-05-21  Simon Marchi  <simon.marchi@ericsson.com>

	* lib/mi-support.exp (mi_run_cmd_full): Add comments.
---
 gdb/testsuite/lib/mi-support.exp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index 6d011b9..26015dc 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -806,6 +806,12 @@ proc mi_gdb_test { args } {
 # In patterns, the newline sequence ``\r\n'' is matched explicitly as
 # ``.*$'' could swallow up output that we attempt to match elsewhere.
 
+# use_mi_command selects whether MI or CLI commands are used by the
+# procedure.
+# args is passed to the command used to run the test program, "run" or
+# "-exec-run", depending on the value of use_mi_command. Therefore, if
+# use_mi_command is false, they are effectively args to the test program.
+# If use_mi_command is true, they are simply arguments to -exec-run.
 proc mi_run_cmd_full {use_mi_command args} {
     global suppress_flag
     if { $suppress_flag } {
-- 
2.0.0.rc0


             reply	other threads:[~2014-05-21 21:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 21:48 Simon Marchi [this message]
2014-05-21 22:26 ` Joel Brobecker
2014-05-22 17:22   ` Simon Marchi
2014-05-22 17:30     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400708905-14184-1-git-send-email-simon.marchi@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox