Re: [PATCH v2 1/3] btrace: control memory access during replay

Eli Zaretskii
2014-05-20T16:12:27Z

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 20 May 2014 14:00:34 +0200
>
> The btrace record target does not trace data. We therefore do not allow
> accessing read-write memory during replay.
>
> In some cases, this might be useful to advanced users, though, who we assume
> to know what they are doing.
>
> Add a set|show command pair to turn this memory access restriction off.

Thanks.

> doc/
> * gdb.texinfo: Document it.

That's not how we format ChangeLog entries in gdb/doc/. Please state
the node name (as if it were a function, in parentheses).

> +@kindex set record btrace
> +The btrace record target does not trace data. As a convenience,
> +when replaying, GDB reads read-only memory off the live program

@value{GDBN}

> +Control the behavior of the @code{btrace} recording method when

Please be consistent about the markup of "btrace": either plain text
or @code{}; pick one and use it everywhere.

> +accessing memory during replay. If READ-ONLY (the default),
> +@value{GDBN} will only allow accesses to read-only memory.
> +If READ-WRITE, @value{GDBN} will allow accesses to read-only and to
> +read-write memory. Beware that the accessed memory corresponds

READ-ONLY and READ-WRITE should be in @code and in lower case.

The documentation part is OK with those fixed.