Re: [PATCH v2 1/3] btrace: control memory access during replay

Pedro Alves
2014-05-20T12:26:19Z

On 05/20/2014 01:00 PM, Markus Metzger wrote:
> The btrace record target does not trace data. We therefore do not allow
> accessing read-write memory during replay.
>
> In some cases, this might be useful to advanced users, though, who we assume
> to know what they are doing.
>
> Add a set|show command pair to turn this memory access restriction off.
>

The code bits are OK.

> + /* Record instructions number limit command. */

This comment looks like a pasto.

> + add_setshow_enum_cmd ("replay-memory-access", no_class,
> + replay_memory_access_types, &replay_memory_access, _("\

Thanks,
--
Pedro Alves