From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, Pedro Alves <pedro@palves.net>,
gdb-patches@sourceware.org,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH][gdb/symtab] Ignore zero line table entries
Date: Tue, 28 Jul 2020 11:49:04 -0400 [thread overview]
Message-ID: <13f44b95-c767-e43b-94bc-c62b895c13b1@simark.ca> (raw)
In-Reply-To: <be080eff-14af-bd99-e9c6-ebfd51b6d354@suse.de>
On 2020-07-24 6:32 p.m., Tom de Vries wrote:
> I've now committed my patch (with the bug in the test-case noticed by
> Pedro fixed by using MACRO_AT_func) as a stopgap. If we decide to go
> with that, we're done. If we decide to try and fix this more precisely,
> we have something to revert back to in case things don't work out.
>
> Thanks,
> - Tom
Ok, thanks to all. So the plan is to revert this once the branch is cut and
apply the various patches (Pedro's and Andrew's, possibly more) necessary to
fix each spot not handling line == 0 well.
Simon
prev parent reply other threads:[~2020-07-28 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 17:49 Tom de Vries
2020-07-21 19:04 ` Simon Marchi
2020-07-24 11:30 ` Pedro Alves
2020-07-24 22:32 ` Tom de Vries
2020-07-28 15:49 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13f44b95-c767-e43b-94bc-c62b895c13b1@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox