From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AaStK5dVfWrXFyIAWB0awg (envelope-from ) for ; Thu, 13 Aug 2026 01:26:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X2su5zvl; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HII3D3I3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C455RBgJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M4ff8rTd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AF07B1E033; Thu, 13 Aug 2026 01:26:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1EA961E033 for ; Thu, 13 Aug 2026 01:26:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB5084BA7988 for ; Thu, 13 Aug 2026 05:26:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB5084BA7988 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X2su5zvl; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HII3D3I3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C455RBgJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M4ff8rTd Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 4C79B4BA23F3 for ; Thu, 13 Aug 2026 05:26:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C79B4BA23F3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C79B4BA23F3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786598781; cv=none; b=nHZsFhJbuPBqqgdXIzxMGo/y++7vCCIBlYAeIRJyxyxZOjs/k8wf4Kw8VM0Avt0ZEA/BukLt7/w9G2bxobZdxkOHo77BPAsir6rC/ox1viOhBomYYo8ShVAtE3/Oqio8ai5SeB/Hqe7mwbmfBbJW0qdEI+M0F2aonEjilt3+niU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786598781; c=relaxed/simple; bh=mD6akfr81mytv+3v8lqEWkXHaB7kXaAIiogRyoMBdNk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=dc9g7v+2+qZ3c5sdgXZrXuqMAaKG/ifznsCVz8ef7wtZ3nMTW0h9T+Ke1X1rkZ9/i4LUF6laoOs8GxtQCw+5KGncIKUwKY2sDcA3A/0Vg7Kn9RcwoG64d8TCCUbzsp5X60JHFqdwO4ceEvZLHoJz8BeyRMQaBbjgyEL/5d+c2NY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=X2su5zvl; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HII3D3I3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C455RBgJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M4ff8rTd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C79B4BA23F3 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6D700827A1; Thu, 13 Aug 2026 05:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786598775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VweQwWf1q5X/mi1oKPHZETKYDvEJDwvX4LQCnq/yMO8=; b=X2su5zvl1YSJlWq9JAEi5V3CDp3uStEm1wlu3rlphI5P8AUAXks8HqmApCi3w60DDJ19za 9EEfUncvAHMNKdwX1vFMzFlYiRZAF/8UVYRJ/QG4S71ogAlaSCKPR0UjqqIHoJSE73LntL WWqUtQ/j1EZewT6ebWL1lobkmkGAUIk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786598775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VweQwWf1q5X/mi1oKPHZETKYDvEJDwvX4LQCnq/yMO8=; b=HII3D3I3OYzQgrWVAMIB23TcdMsaxRXRlaGB5weFhr23An7xOaGvBvHhFtvRh6BE15L8NK 2IHBqAk6E1FsaIAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786598771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VweQwWf1q5X/mi1oKPHZETKYDvEJDwvX4LQCnq/yMO8=; b=C455RBgJsMn2xHnChYPBwowDWSGMZDty1THm2czY2geDN7aXVLWUfsst3tDb2HdZZhcSVH +DT6CeLLdj1HxxaFkofHlBoMVFjKpL2IgTJgE8436c2yQR8rJ2o9EmXs1wa0me6z+RGYnT n6cSqD4nvxtU+o1FXzQSdkUYcTmvIMg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786598771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VweQwWf1q5X/mi1oKPHZETKYDvEJDwvX4LQCnq/yMO8=; b=M4ff8rTdqgUz/tpTh26S1OI2D30Fd/0ApfEM5O4kUgacJ+EPgo8OQOT6khQizlpvPE36Lu T4LqbyidCNnMrNBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 50D0C77C57; Thu, 13 Aug 2026 05:26:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SB7uEXNVfWqjVwAAD6G6ig (envelope-from ); Thu, 13 Aug 2026 05:26:11 +0000 Message-ID: <13e7e583-9314-4c8e-b599-ee9f6a502eae@suse.de> Date: Thu, 13 Aug 2026 07:26:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] [pre-commit] Some pre-commit improvements To: Simon Marchi , gdb-patches@sourceware.org References: <20260720125056.1373177-1-tdevries@suse.de> <25438c2e-fccb-4c2c-8077-a383e4e1a051@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <25438c2e-fccb-4c2c-8077-a383e4e1a051@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/12/26 8:16 PM, Simon Marchi wrote: > On 7/20/26 8:50 AM, Tom de Vries wrote: >> This patch series contains some pre-commit improvements. >> >> The third patch fixes the problem that flake8 is not run for gdb/gdb-gdb.py.in. >> >> The first and second patch fix flake8 problems in gdb/gdb-gdb.py.in. >> >> The fourth and fifth patch makes pre-commit rely less on types filtering, >> fixing PR build/34411. >> >> Tested on x86_64-linux. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34411 >> >> Tom de Vries (5): >> [gdb] Fix bare except in gdb/gdb-gdb.py.in >> [gdb] Remove superfluous global in gdb/gdb-gdb.py.in >> [pre-commit] Run flake8 for gdb/gdb-gdb.py.in >> [pre-commit] Don't require text type for check-whitespace hook >> [pre-commit] Don't require text type for codespell hook > > FYI, I think that patches 1 and 2 are no longer necessary, because the > code has changed. Indeed, thanks for pointing that out. I've now submitted an alternative to patch 3. Patches 4 and 5 still make sense, but both don't apply cleanly without patch 3. So I'll wait what happens with the alternative to decide how to proceed. Thanks, - Tom